Re: Cleanup some -I$(libpq_srcdir) in makefiles

2020-12-29 Thread Michael Paquier
On Tue, Dec 29, 2020 at 05:06:20PM -0500, Tom Lane wrote: > 629b3af2 just moved around the existing -I switch in adminpack/Makefile. > AFAICS that switch goes back to adminpack's introduction, fe59e5666. > It was probably just copied-and-pasted from some other contrib Makefile; > since this Makefil

Re: Cleanup some -I$(libpq_srcdir) in makefiles

2020-12-29 Thread Tom Lane
David Rowley writes: > On Wed, 23 Dec 2020 at 18:07, Michael Paquier wrote: >> adminpack and old_snapshot have no need for those references as they >> don't use libpq. Any objections to a small-ish cleanup that removes >> those references, as per the attached? > I think these can be safely remo

Re: Cleanup some -I$(libpq_srcdir) in makefiles

2020-12-29 Thread David Rowley
On Wed, 23 Dec 2020 at 18:07, Michael Paquier wrote: > While looking at a patch from David, I have noticed $subject: > https://www.postgresql.org/message-id/CAApHDvpgB+vxk=w6opkidwzzeo6knifqidnomzr8p4rotyk...@mail.gmail.com > > adminpack and old_snapshot have no need for those references as they >

Cleanup some -I$(libpq_srcdir) in makefiles

2020-12-22 Thread Michael Paquier
Hi all, While looking at a patch from David, I have noticed $subject: https://www.postgresql.org/message-id/CAApHDvpgB+vxk=w6opkidwzzeo6knifqidnomzr8p4rotyk...@mail.gmail.com adminpack and old_snapshot have no need for those references as they don't use libpq. Any objections to a small-ish clean