> > > I don't see any problem in removing this extra parameter.
> > >
> > > However another thought, can it be used to report a bit meaningful
> > > error for field size < 0 check?
> >
> > column_no was used for that purpose in the past, but commit 0e319c7ad7
> > changed that. If we want to use col
On Thu, Jun 18, 2020 at 10:05 PM Fujii Masao
wrote:
>
>
>
> On 2020/06/18 23:09, Bharath Rupireddy wrote:
> > On Thu, Jun 18, 2020 at 7:01 PM vignesh C wrote:
> >>
> >> Hi,
> >>
> >> While checking copy from code I found that the function parameter
> >> column_no is not used in CopyReadBinaryAttr
On Fri, Jun 19, 2020 at 9:18 AM Tom Lane wrote:
>
> Amit Kapila writes:
> > On Thu, Jun 18, 2020 at 10:05 PM Fujii Masao
> > wrote:
> >> column_no was used for that purpose in the past, but commit 0e319c7ad7
> >> changed that.
>
> > Yeah, but not sure why? By looking at the commit message and c
Amit Kapila writes:
> On Thu, Jun 18, 2020 at 10:05 PM Fujii Masao
> wrote:
>> column_no was used for that purpose in the past, but commit 0e319c7ad7
>> changed that.
> Yeah, but not sure why? By looking at the commit message and change
> it is difficult to say why it has been removed? Tom has
On Thu, Jun 18, 2020 at 10:05 PM Fujii Masao
wrote:
>
>
> On 2020/06/18 23:09, Bharath Rupireddy wrote:
> > On Thu, Jun 18, 2020 at 7:01 PM vignesh C wrote:
> >>
> >> Hi,
> >>
> >> While checking copy from code I found that the function parameter
> >> column_no is not used in CopyReadBinaryAttrib
On 2020/06/18 23:09, Bharath Rupireddy wrote:
On Thu, Jun 18, 2020 at 7:01 PM vignesh C wrote:
Hi,
While checking copy from code I found that the function parameter
column_no is not used in CopyReadBinaryAttribute. I felt this could be
removed.
Attached patch contains the changes for the s
On Thu, Jun 18, 2020 at 7:01 PM vignesh C wrote:
>
> Hi,
>
> While checking copy from code I found that the function parameter
> column_no is not used in CopyReadBinaryAttribute. I felt this could be
> removed.
> Attached patch contains the changes for the same.
> Thoughts?
>
I don't see any prob
a26d6d45c6f7f8d9effb0965f8893725bda2a288 Mon Sep 17 00:00:00 2001
From: Vignesh C
Date: Thu, 18 Jun 2020 18:45:52 +0530
Subject: [PATCH] Cleanup, removal of unused function parameter from
CopyReadBinaryAttribute.
The function parameter column_no is not used in CopyReadBinaryAttribute, this
can be removed.
---
src
