Few comments seem to have dangling references to the behavior from pre-12 "WITH
OIDS". Maybe varsup.c should get a wider change?
diff --git a/src/backend/access/common/tupdesc.c
b/src/backend/access/common/tupdesc.c
index 1e743d7d86..ce84e22cbd 100644
--- a/src/backend/access/common/tupdesc.c
++
Justin Pryzby writes:
> I'm resending this patch, which still seems to be needed.
Yeah, clearly one copy of that text got missed out. Pushed that.
> Also, should this be removed ? Or at leat remove the parenthesized text,
> since
> non-system tables no longer have OIDs: "(use to avoid output
a80312360ef7 Mon Sep 17 00:00:00 2001
> From: Justin Pryzby
> Date: Wed, 8 May 2019 13:57:12 -0500
> Subject: [PATCH v1] Cleanup/remove/update references to OID column...
>
> ..in wake of 578b229718e8f.
>
> See also
> 93507e67c9ca54026019eb
I found what appears to be a dangling reference to old "hidden" OID behavior.
Justin
>From 1c6712c0ade949648dbc415dfd7ea80312360ef7 Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Wed, 8 May 2019 13:57:12 -0500
Subject: [PATCH v1] Cleanup/remove/update references to OID column.
On Wed, Apr 17, 2019 at 11:14:13PM -0500, Justin Pryzby wrote:
> On Wed, Apr 17, 2019 at 05:51:15PM -0700, Andres Freund wrote:
> > > - rows was exactly one and the target table
> > > was
> > > + count was exactly one and the target table
> > > was
> > The rows reference is from your change
>
On Wed, Apr 17, 2019 at 05:51:15PM -0700, Andres Freund wrote:
> Hi,
>
> On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> > diff --git a/doc/src/sgml/information_schema.sgml
> > b/doc/src/sgml/information_schema.sgml
> > index 234a3bb..9c618b1 100644
> > --- a/doc/src/sgml/information_schema.
Hi,
On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> diff --git a/doc/src/sgml/information_schema.sgml
> b/doc/src/sgml/information_schema.sgml
> index 234a3bb..9c618b1 100644
> --- a/doc/src/sgml/information_schema.sgml
> +++ b/doc/src/sgml/information_schema.sgml
> @@ -1312,8 +1312,8 @@
>
Tue, 2 Apr 2019 19:13:55 -0500
Subject: [PATCH v3] Cleanup/remove/update references to OID column...
..in wake of 578b229718e8f.
See also
93507e67c9ca54026019ebec3026de35d30370f9
1464755fc490a9911214817fe83077a3689250ab
Author: Justin Pryzby
Author: Daniel Verite
---
doc/sr
Hi,
On 2019-04-15 18:35:12 +0200, Daniel Verite wrote:
> Andres Freund wrote:
>
> > Yes, I was planning to commit that soon-ish. There still seemed
> > review / newer versions happening, though, so I was thinking of waiting
> > for a bit longer.
>
> You might want to apply this trivial one
Hi,
On 2019-04-10 11:59:18 -0500, Justin Pryzby wrote:
> @@ -1202,8 +1202,7 @@ CREATE TABLE circles (
>ctid will change if it is
>updated or moved by VACUUM FULL. Therefore
>ctid is useless as a long-term row
> - identifier. The OID, or even better a user-defined ser
Andres Freund wrote:
> Yes, I was planning to commit that soon-ish. There still seemed
> review / newer versions happening, though, so I was thinking of waiting
> for a bit longer.
You might want to apply this trivial one in the same batch:
index 452f307..7cfb67f 100644
--- a/src/bin/pg_
On Thu, Apr 11, 2019 at 08:39:42AM -0700, Andres Freund wrote:
> Yes, I was planning to commit that soon-ish. There still seemed
> review / newer versions happening, though, so I was thinking of waiting
> for a bit longer.
I don't expect anything new.
I got all that from: git grep '>oid' doc/src/
Hi,
On 2019-04-11 13:26:38 +0900, Michael Paquier wrote:
> On Wed, Apr 10, 2019 at 11:59:18AM -0500, Justin Pryzby wrote:
> > I found and included fixes for a few more references:
> >
> > doc/src/sgml/catalogs.sgml | 2 +-
> > doc/src/sgml/ddl.sgml| 3 +--
> > doc/src/s
On Wed, Apr 10, 2019 at 11:59:18AM -0500, Justin Pryzby wrote:
> I found and included fixes for a few more references:
>
> doc/src/sgml/catalogs.sgml | 2 +-
> doc/src/sgml/ddl.sgml| 3 +--
> doc/src/sgml/information_schema.sgml | 4 ++--
> doc/src/sgml/ref/create_trigge
On Wed, Apr 10, 2019 at 06:32:35PM +0200, Daniel Verite wrote:
> Justin Pryzby wrote:
>
> > Cleanup/remove/update references to OID column...
>
> Just spotted a couple of other references that need updates:
> #1. In catalogs.sgml:
> #2. In ddl.sgml, when descr
Justin Pryzby wrote:
> Cleanup/remove/update references to OID column...
>
> ..in wake of 578b229718e8f.
Just spotted a couple of other references that need updates:
#1. In catalogs.sgml:
attnum
int2
The number of the column. Ordinar
Cleanup/remove/update references to OID column...
..in wake of 578b229718e8f.
See also
93507e67c9ca54026019ebec3026de35d30370f9
1464755fc490a9911214817fe83077a3689250ab
---
doc/src/sgml/ddl.sgml | 9 -
doc/src/sgml/ref/insert.sgml | 12 +---
doc/src/sgml/ref/psql
17 matches
Mail list logo
