Re: Clean up some old cruft related to Windows

2020-02-20 Thread Michael Paquier
On Thu, Feb 20, 2020 at 12:39:56PM +0100, Juan José Santamaría Flecha wrote: > Actually, you can still use the vcvars% scripts to configure architecture, > platform_type and winsdk_version with current VS [1]. We still support the build down to MSVC 2013, so I think that it is good to mention the

Re: Clean up some old cruft related to Windows

2020-02-20 Thread Juan José Santamaría Flecha
On Thu, Feb 20, 2020 at 4:23 AM Michael Paquier wrote: > > + You can change certain build options, such as the targeted CPU > + architecture, build type, and the selection of the SDK by using either > + VSVARS32.bat or VsDevCmd.bat > depending > + on your Visual Studio release. All commands >

Re: Clean up some old cruft related to Windows

2020-02-19 Thread Michael Paquier
On Wed, Feb 19, 2020 at 07:02:55PM +0100, Juan José Santamaría Flecha wrote: > Please find a patched for so. I have tried to make it more version > neutral. + You can change certain build options, such as the targeted CPU + architecture, build type, and the selection of the SDK by using either +

Re: Clean up some old cruft related to Windows

2020-02-19 Thread Juan José Santamaría Flecha
On Wed, Feb 19, 2020 at 4:49 AM Michael Paquier wrote: > On Tue, Feb 18, 2020 at 12:26:06PM +0100, Juan José Santamaría Flecha > wrote: > > I cannot point when SetEnv.bat was exactly dropped, probably Windows 7 > SDK > > was the place where it was *last* included [1], so that needs to be > update

Re: Clean up some old cruft related to Windows

2020-02-18 Thread Michael Paquier
On Tue, Feb 18, 2020 at 05:54:43PM +0900, Kyotaro Horiguchi wrote: > I understand that this is not for back-patching. Cleanups don't go to back-branches. > At Tue, 18 Feb 2020 16:44:59 +0900, Michael Paquier > wrote in > The unmodified section just above is griping that "Strange they call > UN

Re: Clean up some old cruft related to Windows

2020-02-18 Thread Michael Paquier
On Tue, Feb 18, 2020 at 12:26:06PM +0100, Juan José Santamaría Flecha wrote: > I cannot point when SetEnv.bat was exactly dropped, probably Windows 7 SDK > was the place where it was included [1], so that needs to be updated. > > Using VS2019 and VS2017 this would be done using VsDevCmd.bat [2], w

Re: Clean up some old cruft related to Windows

2020-02-18 Thread Michael Paquier
On Tue, Feb 18, 2020 at 12:05:42PM +0100, Juan José Santamaría Flecha wrote: > Maybe this needs a specific thread, as it is not quite cruft but something > that will require maintenance. Makes sense. I have discarded that part for now. -- Michael signature.asc Description: PGP signature

Re: Clean up some old cruft related to Windows

2020-02-18 Thread Juan José Santamaría Flecha
On Tue, Feb 18, 2020 at 12:26 PM Juan José Santamaría Flecha < juanjo.santama...@gmail.com> wrote: > > [Edit] ... probably Windows 7 SDK was the *last* place where it was included [1]... > > Regards, > > Juan José Santamaría Flecha >

Re: Clean up some old cruft related to Windows

2020-02-18 Thread Juan José Santamaría Flecha
On Tue, Feb 18, 2020 at 9:56 AM Kyotaro Horiguchi wrote: > > https://www.postgresql.org/docs/current/install-windows-full.html > > In recent SDK versions you can change the targeted CPU architecture, > > build type, and target OS by using the setenv command, e.g. setenv > > /x86 /release /xp to t

Re: Clean up some old cruft related to Windows

2020-02-18 Thread Juan José Santamaría Flecha
On Tue, Feb 18, 2020 at 7:54 AM Michael Paquier wrote: > On Thu, Dec 19, 2019 at 08:09:45PM +0100, Juan José Santamaría Flecha > wrote: > > This is probably not an issue for the supported MSVC and their SDK, but > > current MinGW defaults to Windows 2003 [1]. So I would suggest a logic > like: >

Re: Clean up some old cruft related to Windows

2020-02-18 Thread Kyotaro Horiguchi
Hello. I understand that this is not for back-patching. At Tue, 18 Feb 2020 16:44:59 +0900, Michael Paquier wrote in > On Thu, Dec 19, 2019 at 01:46:33PM +0900, Kyotaro Horiguchi wrote: > > I found some similar places by grep'ing for windows version names the > > whole source tree. > > > > -

Re: Clean up some old cruft related to Windows

2020-02-17 Thread Michael Paquier
On Thu, Dec 19, 2019 at 01:46:33PM +0900, Kyotaro Horiguchi wrote: > I found some similar places by grep'ing for windows version names the > whole source tree. > > - The comment for trapsig is mentioning win98/Me/NT/2000/XP. Let's refresh the comment here, as per the following: https://docs.micro

Re: Clean up some old cruft related to Windows

2020-02-17 Thread Michael Paquier
On Thu, Dec 19, 2019 at 08:09:45PM +0100, Juan José Santamaría Flecha wrote: > This is probably not an issue for the supported MSVC and their SDK, but > current MinGW defaults to Windows 2003 [1]. So I would suggest a logic like: > > #define WINNTVER(ver) ((ver) >> 16) > #define NTDDI_VERSION 0x06

Re: Clean up some old cruft related to Windows

2019-12-19 Thread Juan José Santamaría Flecha
On Thu, Dec 19, 2019 at 5:47 AM Kyotaro Horiguchi wrote: > At Thu, 19 Dec 2019 11:15:26 +0900, Michael Paquier > wrote in > > Hi all, > > > > As discussed here, there is in the tree a couple of things related to > > past versions of Windows: > > > https://www.postgresql.org/message-id/2019121802

Re: Clean up some old cruft related to Windows

2019-12-18 Thread Kyotaro Horiguchi
At Thu, 19 Dec 2019 11:15:26 +0900, Michael Paquier wrote in > Hi all, > > As discussed here, there is in the tree a couple of things related to > past versions of Windows: > https://www.postgresql.org/message-id/201912180219susv254.ge1...@paquier.xyz > > So I have been looking at that more cl

Clean up some old cruft related to Windows

2019-12-18 Thread Michael Paquier
Hi all, As discussed here, there is in the tree a couple of things related to past versions of Windows: https://www.postgresql.org/message-id/20191218021954.ge1...@paquier.xyz So I have been looking at that more closely, and found more: - MIN_WINNT can be removed from win32.h thanks to d9dd406 wh