Re: Checks in RegisterBackgroundWorker.()

2023-10-09 Thread Heikki Linnakangas
On 06/10/2023 13:13, Thomas Munro wrote: On Thu, Sep 28, 2023 at 9:46 AM Heikki Linnakangas wrote: Subject: [PATCH v2 3/3] Fix misleading comment on StartBackgroundWorker(). LGTM. Hmm, maybe I would have called that function "BackgroundWorkerMain()" like several other similar things, but tha

Re: Checks in RegisterBackgroundWorker.()

2023-10-06 Thread Thomas Munro
On Thu, Sep 28, 2023 at 9:46 AM Heikki Linnakangas wrote: > Here's a new version of these patches. I fixed one comment and ran > pgindent, no other changes. > Subject: [PATCH v2 1/3] Clarify the checks in RegisterBackgroundWorker. LGTM. I see it passes on CI, and I also teste

Re: Checks in RegisterBackgroundWorker.()

2023-09-27 Thread Heikki Linnakangas
CH v2 1/3] Clarify the checks in RegisterBackgroundWorker. In EXEC_BACKEND or single-user mode, we process shared_preload_libraries at postmaster startup as usual, but also at backend startup. When a library calls RegisterBackgroundWorker() when being loaded into a backend process, we go throug

Re: Checks in RegisterBackgroundWorker.()

2023-09-19 Thread Heikki Linnakangas
On 25/08/2023 00:00, Thomas Munro wrote: On Fri, Aug 25, 2023 at 3:15 AM Heikki Linnakangas wrote: In summary, RegisterBackgroundWorker() is doing some questionable and useless work, when a shared preload library is loaded to a backend process in EXEC_BACKEND mode. Yeah. When I was working o

Re: Checks in RegisterBackgroundWorker.()

2023-08-24 Thread Thomas Munro
On Fri, Aug 25, 2023 at 3:15 AM Heikki Linnakangas wrote: > In summary, RegisterBackgroundWorker() is doing some questionable and > useless work, when a shared preload library is loaded to a backend > process in EXEC_BACKEND mode. Yeah. When I was working on 7389aad6 ("Use WaitEventSet API for p

Checks in RegisterBackgroundWorker.()

2023-08-24 Thread Heikki Linnakangas
-- Heikki Linnakangas Neon (https://neon.tech)From b6475511099646f1fab0ba3cfcf5651e52de634b Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Thu, 24 Aug 2023 18:08:39 +0300 Subject: [PATCH 1/3] Clarify the checks in RegisterBackgroundWorker. In EXEC_BACKEND or single-user mode, we process shared