Thanks for pushing.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
On 10/01/2025 05:11, Peter Smith wrote:
On Sun, Dec 8, 2024 at 10:57 AM Tomas Vondra wrote:
Yes, there are cases with logical replication where reproducing may be
expensive (in terms of data amounts, time, ...) but I don't think that's
the case here - this test is trivial/cheap.
But I believe
On Sun, Dec 8, 2024 at 10:57 AM Tomas Vondra wrote:
>
> On 8/22/24 05:21, Peter Smith wrote:
> > ...
> >>>
> >>> I also don't see a test for this error condition. However, it is not
> >>> clear to me how important is it to cover this error code path. This
> >>> code has existed for a long time and
On 8/22/24 05:21, Peter Smith wrote:
> ...
>>>
>>> I also don't see a test for this error condition. However, it is not
>>> clear to me how important is it to cover this error code path. This
>>> code has existed for a long time and I didn't notice any bugs related
>>> to this. There is a possibili
On Thu, Aug 22, 2024 at 8:54 AM Peter Smith wrote:
>
> On Wed, Aug 21, 2024 at 8:48 PM Amit Kapila wrote:
> >
> > On Fri, Aug 16, 2024 at 9:45 AM vignesh C wrote:
> > >
> > > On Thu, 15 Aug 2024 at 12:55, Peter Smith wrote:
> > > >
> > > > Hi Hackers,
> > > >
> > > > While reviewing another log
On Wed, Aug 21, 2024 at 8:48 PM Amit Kapila wrote:
>
> On Fri, Aug 16, 2024 at 9:45 AM vignesh C wrote:
> >
> > On Thu, 15 Aug 2024 at 12:55, Peter Smith wrote:
> > >
> > > Hi Hackers,
> > >
> > > While reviewing another logical replication thread [1], I found an
> > > ERROR scenario that seems
On Fri, Aug 16, 2024 at 9:45 AM vignesh C wrote:
>
> On Thu, 15 Aug 2024 at 12:55, Peter Smith wrote:
> >
> > Hi Hackers,
> >
> > While reviewing another logical replication thread [1], I found an
> > ERROR scenario that seems to be untested.
> >
> > TEST CASE: Attempt CREATE SUBSCRIPTION where t
On Tue, 20 Aug 2024 at 08:21, Peter Smith wrote:
>
> On Fri, Aug 16, 2024 at 2:15 PM vignesh C wrote:
> >
>
> Thanks for the review.
>
> >
> > I agree currently there is no test to hit this code. I'm not sure if
> > this is the correct location for the test, should it be included in
> > the 008_d
On Fri, Aug 16, 2024 at 2:15 PM vignesh C wrote:
>
Thanks for the review.
>
> I agree currently there is no test to hit this code. I'm not sure if
> this is the correct location for the test, should it be included in
> the 008_diff_schema.pl file?
Yes, that is a better home for this test. Done
On Thu, 15 Aug 2024 at 12:55, Peter Smith wrote:
>
> Hi Hackers,
>
> While reviewing another logical replication thread [1], I found an
> ERROR scenario that seems to be untested.
>
> TEST CASE: Attempt CREATE SUBSCRIPTION where the subscriber table is
> missing some expected column(s).
>
> Attach
Hi Hackers,
While reviewing another logical replication thread [1], I found an
ERROR scenario that seems to be untested.
TEST CASE: Attempt CREATE SUBSCRIPTION where the subscriber table is
missing some expected column(s).
Attached is a patch to add the missing test for this error message.
11 matches
Mail list logo
