On Fri, Nov 28, 2025 at 1:34 AM Fujii Masao wrote:
>
> On Thu, Nov 27, 2025 at 7:25 AM Peter Smith wrote:
> > Here are the back patches as requested. I hope they are OK.
>
> Thanks for the patches! I've pushed them.
>
Thanks for pushing! I enjoyed the discussions in this thread and
learned some
On Thu, Nov 27, 2025 at 7:25 AM Peter Smith wrote:
> Here are the back patches as requested. I hope they are OK.
Thanks for the patches! I've pushed them.
Regards,
--
Fujii Masao
On Tue, Nov 25, 2025 at 10:47 PM Chao Li wrote:
>
>
>
> > On Nov 25, 2025, at 18:42, Fujii Masao wrote:
> >
> > On Fri, Nov 21, 2025 at 3:27 PM Chao Li wrote:
> >>
> >>
> >>
> >>> On Nov 21, 2025, at 05:08, Peter Smith wrote:
> >>>
> >>> I've reverted the ALTER 'publication_drop_object' part to
> On Nov 25, 2025, at 18:42, Fujii Masao wrote:
>
> On Fri, Nov 21, 2025 at 3:27 PM Chao Li wrote:
>>
>>
>>
>>> On Nov 21, 2025, at 05:08, Peter Smith wrote:
>>>
>>> I've reverted the ALTER 'publication_drop_object' part to be the same
>>> as master (i.e. removed the v6 'table' replaceme
On Fri, Nov 21, 2025 at 3:27 PM Chao Li wrote:
>
>
>
> > On Nov 21, 2025, at 05:08, Peter Smith wrote:
> >
> > I've reverted the ALTER 'publication_drop_object' part to be the same
> > as master (i.e. removed the v6 'table' replacement) after Fujii-San
> > showed [1] that the original synopsis st
> On Nov 21, 2025, at 05:08, Peter Smith wrote:
>
> I've reverted the ALTER 'publication_drop_object' part to be the same
> as master (i.e. removed the v6 'table' replacement) after Fujii-San
> showed [1] that the original synopsis style is present on some other
> documentation pages.
>
> PSS
I've reverted the ALTER 'publication_drop_object' part to be the same
as master (i.e. removed the v6 'table' replacement) after Fujii-San
showed [1] that the original synopsis style is present on some other
documentation pages.
PSS new patch v7.
==
[1]
https://www.postgresql.org/message-id/C
On Thu, Nov 20, 2025 at 2:06 PM Chao Li wrote:
>
>
>
> > On Nov 20, 2025, at 09:41, Peter Smith wrote:
> >
> > On Thu, Nov 20, 2025 at 12:03 PM Fujii Masao wrote:
> >>
> >> On Thu, Nov 20, 2025 at 9:02 AM Chao Li wrote:
> >>> V6 looks better.
> >>
> >> +1. Thanks for updating the patch!
> >>
>
> On Nov 20, 2025, at 09:41, Peter Smith wrote:
>
> On Thu, Nov 20, 2025 at 12:03 PM Fujii Masao wrote:
>>
>> On Thu, Nov 20, 2025 at 9:02 AM Chao Li wrote:
>>> V6 looks better.
>>
>> +1. Thanks for updating the patch!
>>
>> +and table is:
>> +
>> +[ ONLY ] table_name [ * ]
>>
>> I h
On Thu, Nov 20, 2025 at 12:03 PM Fujii Masao wrote:
>
> On Thu, Nov 20, 2025 at 9:02 AM Chao Li wrote:
> > V6 looks better.
>
> +1. Thanks for updating the patch!
>
> +and table is:
> +
> +[ ONLY ] table_name [ * ]
>
> I have one question: in lock.sgml and truncate.sgml, the syntax
> "[ ONLY
On Thu, Nov 20, 2025 at 9:02 AM Chao Li wrote:
> V6 looks better.
+1. Thanks for updating the patch!
+and table is:
+
+[ ONLY ] table_name [ * ]
I have one question: in lock.sgml and truncate.sgml, the syntax
"[ ONLY ] name [ * ] [, ... ]" seems shown as acceptable (though
I'm not entirely
On Thu, Nov 20, 2025 at 11:02 AM Chao Li wrote:
>
>
>
> > On Nov 20, 2025, at 06:18, Peter Smith wrote:
> >
> > Hi Fuji-San.
> >
> > Thanks for your suggestions! I've attached a new patch v6 to incorporate
> > them.
> >
> > On Thu, Nov 20, 2025 at 4:50 AM Fujii Masao wrote:
> >>
> >> On Tue, N
> On Nov 20, 2025, at 06:18, Peter Smith wrote:
>
> Hi Fuji-San.
>
> Thanks for your suggestions! I've attached a new patch v6 to incorporate
> them.
>
> On Thu, Nov 20, 2025 at 4:50 AM Fujii Masao wrote:
>>
>> On Tue, Nov 18, 2025 at 5:27 PM Chao Li wrote:
>>> Thanks for addressing the
Hi Fuji-San.
Thanks for your suggestions! I've attached a new patch v6 to incorporate them.
On Thu, Nov 20, 2025 at 4:50 AM Fujii Masao wrote:
>
> On Tue, Nov 18, 2025 at 5:27 PM Chao Li wrote:
> > Thanks for addressing the comments. V5 looks good to me.
>
> Thanks both for the patch and revie
On Tue, Nov 18, 2025 at 5:27 PM Chao Li wrote:
> Thanks for addressing the comments. V5 looks good to me.
Thanks both for the patch and review!
-where all_publication_object is one
of:
+where table_spec is:
+
+[ ONLY ] table_name [ * ] [ ( column_name [, ... ] ) ] [ WHERE (
expressio
> On Nov 18, 2025, at 13:31, Peter Smith wrote:
>
> On Mon, Nov 17, 2025 at 5:49 PM Chao Li wrote:
> ...
>>> #1.
>>> My original change, to fix the [, ...] grouping to remove ambiguity.
>>>
>>> #2
>>> Now renames "all_publication_object" to "publication_all_objects".
>>> This is a simple nam
On Mon, Nov 17, 2025 at 5:49 PM Chao Li wrote:
...
> > #1.
> > My original change, to fix the [, ...] grouping to remove ambiguity.
> >
> > #2
> > Now renames "all_publication_object" to "publication_all_objects".
> > This is a simple name change that does not affect anything. I felt
> > everythin
> On Nov 17, 2025, at 14:48, Chao Li wrote:
>
>> #2
>> Now renames "all_publication_object" to "publication_all_objects".
>> This is a simple name change that does not affect anything. I felt
>> everything ought to have the prefix of the object it belongs to (e.g.
>> "publication_name", "publi
> On Nov 17, 2025, at 08:30, Peter Smith wrote:
>
> On Fri, Nov 14, 2025 at 7:02 PM Chao Li wrote:
>>
>>
>>
>>> On Nov 14, 2025, at 15:47, Fujii Masao wrote:
>>>
>>> On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote:
A rebase was needed. Here is patch v3.
>>>
>>> Thanks for
On Fri, Nov 14, 2025 at 7:02 PM Chao Li wrote:
>
>
>
> > On Nov 14, 2025, at 15:47, Fujii Masao wrote:
> >
> > On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote:
> >>
> >> A rebase was needed. Here is patch v3.
> >
> > Thanks for the patch! LGTM.
> >
> > For example, in the CREATE PUBLICATION s
> On Nov 14, 2025, at 15:47, Fujii Masao wrote:
>
> On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote:
>>
>> A rebase was needed. Here is patch v3.
>
> Thanks for the patch! LGTM.
>
> For example, in the CREATE PUBLICATION synopsis, the part that can be
> repeated is "[ ONLY ] table_name
On Fri, Nov 14, 2025 at 10:23 AM Peter Smith wrote:
>
> A rebase was needed. Here is patch v3.
Thanks for the patch! LGTM.
For example, in the CREATE PUBLICATION synopsis, the part that can be
repeated is "[ ONLY ] table_name ... [ WHERE ( expression ) ]" not just
the WHERE clause, so using curl
A rebase was needed. Here is patch v3.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
v3-0001-Add-curly-brackets-before-ellipsis.patch
Description: Binary data
A rebase was needed. Here is patch v2.
==
Kind Regards,
Peter Smith.
Fujitsu Australia
v2-0001-Add-curly-brackets-before-ellipsis.patch
Description: Binary data
Added a CF entry [1] for this.
==
[1] https://commitfest.postgresql.org/patch/6062/
Kind Regards,
Peter Smith.
Fujitsu Australia
During some recent reviews in this area, I noticed both CREATE/ALTER
PUBLICATION synopses say:
--
where publication_object is one of:
TABLE [ ONLY ] table_name [ * ] [ ( column_name [, ... ] ) ] [
WHERE ( expression ) ] [, ... ]
TABLES IN SCHEMA { schema_name | CURRENT_SCHEMA } [,
26 matches
Mail list logo
