Re: Busted includes somewhere near worker_internal.h

2020-07-18 Thread Tom Lane
Andres Freund writes: > On 2020-07-17 16:09:14 -0400, Tom Lane wrote: >> headerscheck and cpluspluscheck are both unhappy about this: >> ./src/include/replication/worker_internal.h:49:2: error: unknown type name >> 'slock_t' >> slock_t relmutex; >> ^~~ > I think including spin.h i

Re: Busted includes somewhere near worker_internal.h

2020-07-17 Thread Andres Freund
Hi, On 2020-07-17 16:09:14 -0400, Tom Lane wrote: > headerscheck and cpluspluscheck are both unhappy about this: > > ./src/include/replication/worker_internal.h:49:2: error: unknown type name > 'slock_t' > slock_t relmutex; > ^~~ > > Now, worker_internal.h itself hasn't changed in some

Busted includes somewhere near worker_internal.h

2020-07-17 Thread Tom Lane
headerscheck and cpluspluscheck are both unhappy about this: ./src/include/replication/worker_internal.h:49:2: error: unknown type name 'slock_t' slock_t relmutex; ^~~ Now, worker_internal.h itself hasn't changed in some time. I conclude that somebody rearranged one of the header files