Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages

2018-07-19 Thread Alexander Korotkov
Thu, Jul 19, 2018 at 9:29 PM Alvaro Herrera wrote: > On 2018-Jul-19, Alexander Korotkov wrote: > > > Pushed, thanks! > > I think you missed branch REL_11_STABLE ... > Thank you for noticing! I also have just discovered that while looking at buildfarm. Fixed. -- Alexander Korotkov Postgre

Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages

2018-07-19 Thread Alvaro Herrera
On 2018-Jul-19, Alexander Korotkov wrote: > Pushed, thanks! I think you missed branch REL_11_STABLE ... -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages

2018-07-19 Thread Alexander Korotkov
On Thu, Jul 19, 2018 at 6:17 PM R, Siva wrote: > > On Thu, Jul 19, 2018 at 2:43 PM Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > > It appears that we need to handle empty posting list pages also > in disassembleLeaf(). Updated patch is attached. I'm > > going to commit it. > Thank

Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages

2018-07-19 Thread Alexander Korotkov
On Thu, Jul 19, 2018 at 2:43 PM Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Wed, Jul 18, 2018 at 11:59 AM Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> On Wed, Jul 18, 2018 at 1:40 AM R, Siva wrote: >> >>> We came across an issue during replay of a gin insert recor

Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages

2018-07-19 Thread Alexander Korotkov
Hi! On Wed, Jul 18, 2018 at 11:59 AM Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Wed, Jul 18, 2018 at 1:40 AM R, Siva wrote: > >> We came across an issue during replay of a gin insert record on a pre-9.4 >> uncompressed data leaf page that does not have any items in it. The engin

Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages

2018-07-18 Thread Alexander Korotkov
Hi! On Wed, Jul 18, 2018 at 1:40 AM R, Siva wrote: > We came across an issue during replay of a gin insert record on a pre-9.4 > uncompressed data leaf page that does not have any items in it. The engine > version where the replay is done is 9.6.3. The redo logic attempts to > compress the exist