Re: Bug: When user-defined AM is used, the index path cannot be selected correctly

2022-09-01 Thread Tom Lane
I wrote: > I think we need something more like the attached. Meh -- serves me right for not doing check-world before sending. The patch causes some plans to change in the btree_gin and btree_gist modules; which is good, because that shows that the patch is actually doing what it's supposed to. Th

Re: Bug: When user-defined AM is used, the index path cannot be selected correctly

2022-09-01 Thread Tom Lane
Quan Zongliang writes: > New patch attached. > It seems that partitions do not use AM other than btree and hash. > Rewrite only indxpath.c and check if it is a custom AM. This seems drastically underdocumented, and the test you're using for extension opclasses is wrong. What we need to know befo

Re: Bug: When user-defined AM is used, the index path cannot be selected correctly

2022-08-17 Thread Quan Zongliang
On 2022/8/17 10:03, Tom Lane wrote: Quan Zongliang writes: 1. When using extended PGroonga ... 3. Neither ID = 'f' nor id= 't' can use the index correctly. This works fine for btree indexes. I think the actual problem is that IsBooleanOpfamily only accepts the btree and hash opclasses, and

Re: Bug: When user-defined AM is used, the index path cannot be selected correctly

2022-08-16 Thread Tom Lane
Quan Zongliang writes: > 1. When using extended PGroonga > ... > 3. Neither ID = 'f' nor id= 't' can use the index correctly. This works fine for btree indexes. I think the actual problem is that IsBooleanOpfamily only accepts the btree and hash opclasses, and that's what needs to be improved.

Bug: When user-defined AM is used, the index path cannot be selected correctly

2022-08-16 Thread Quan Zongliang
Hi, 1. When using extended PGroonga CREATE EXTENSION pgroonga; CREATE TABLE memos ( id boolean, content varchar ); CREATE INDEX idxA ON memos USING pgroonga (id); 2. Disable bitmapscan and seqscan: SET enable_seqscan=off; SET enable_indexscan=on; SET enable_bitmapscan=off; 3. Neither I