Re: Bogus EPQ plan construction in postgres_fdw

2018-12-14 Thread Robert Haas
On Wed, Dec 12, 2018 at 8:00 PM Tom Lane wrote: > By chance I noticed that postgres_fdw's postgresGetForeignPlan() assumes > --- without any checking --- that the outer_plan it's given for a join > relation must have a NestLoop, MergeJoin, or HashJoin node at the top. > That's been wrong at least

Bogus EPQ plan construction in postgres_fdw

2018-12-12 Thread Tom Lane
By chance I noticed that postgres_fdw's postgresGetForeignPlan() assumes --- without any checking --- that the outer_plan it's given for a join relation must have a NestLoop, MergeJoin, or HashJoin node at the top. That's been wrong at least since commit 4bbf6edfb (which could cause insertion of a