Re: Blank archive_command

2022-01-17 Thread Tom Lane
Robert Haas writes: > It might be nice to do something about the fact that you can't change > archive_mode without a server restart, though. I suspect we had a good > reason for that limitation from an engineering perspective, but from a > user perspective, it sucks pretty hard. Agreed. I don't

Re: Blank archive_command

2022-01-17 Thread Robert Haas
On Mon, Jan 17, 2022 at 10:53 AM Bharath Rupireddy wrote: > This parameter can only be set in the postgresql.conf file or on the > server command line. It is ignored unless archive_mode was enabled at > server start. If archive_command is an empty string (the default) > while archive_mode is enabl

Re: Blank archive_command

2022-01-17 Thread Bharath Rupireddy
On Mon, Jan 17, 2022 at 9:05 PM Bharath Rupireddy wrote: > > +1 to not create any GUC setting dependencies. Let's leave the > responsibility of setting appropriate archive_command to the archiving > handlers outside postgres. FWIW, having a note in the archive_command > GUC definition in the docs

Re: Blank archive_command

2022-01-17 Thread Thom Brown
On Mon, 17 Jan 2022 at 15:25, Bharath Rupireddy wrote: > > On Mon, Jan 17, 2022 at 8:14 PM Thom Brown wrote: > > > > Hi, > > > > Should archive_command being blank when archiving is enabled result in > > a fatal error? This doesn't even produce a warning when restarting, > > just an entry in the

Re: Blank archive_command

2022-01-17 Thread Bharath Rupireddy
On Mon, Jan 17, 2022 at 9:02 PM Tom Lane wrote: > > Bharath Rupireddy writes: > > However, a reasonable thing to do is to > > emit a WARNING or ERROR-out when archive_command is set to null in > > it's check_archive_command when archive_mode is on? > > We have been burned badly in the past by att

Re: Blank archive_command

2022-01-17 Thread Tom Lane
Bharath Rupireddy writes: > However, a reasonable thing to do is to > emit a WARNING or ERROR-out when archive_command is set to null in > it's check_archive_command when archive_mode is on? We have been burned badly in the past by attempts to do that sort of thing (ie, make behavior that's condi

Re: Blank archive_command

2022-01-17 Thread Bharath Rupireddy
On Mon, Jan 17, 2022 at 8:14 PM Thom Brown wrote: > > Hi, > > Should archive_command being blank when archiving is enabled result in > a fatal error? This doesn't even produce a warning when restarting, > just an entry in the log when it goes to archive a WAL segment, and > finds the archive_comm

Blank archive_command

2022-01-17 Thread Thom Brown
Hi, Should archive_command being blank when archiving is enabled result in a fatal error? This doesn't even produce a warning when restarting, just an entry in the log when it goes to archive a WAL segment, and finds the archive_command is empty. Is there a valid scenario where someone would hav