Re: Bizarre coding in recovery target GUC management

2020-10-23 Thread Peter Eisentraut
On 2020-10-12 18:00, Tom Lane wrote: Would someone explain to me why assign_recovery_target_lsn and related GUC assign hooks throw errors, rather than doing so in the associated check hooks? An assign hook is not supposed to throw an error. Full stop, no exceptions. We wouldn't bother to separ

Bizarre coding in recovery target GUC management

2020-10-12 Thread Tom Lane
Would someone explain to me why assign_recovery_target_lsn and related GUC assign hooks throw errors, rather than doing so in the associated check hooks? An assign hook is not supposed to throw an error. Full stop, no exceptions. We wouldn't bother to separate those hooks otherwise.