Re: Better HINT message for "unexpected data beyond EOF"

2025-07-29 Thread Robert Haas
On Mon, Jul 28, 2025 at 2:42 PM Nathan Bossart wrote: > On Mon, Jul 28, 2025 at 11:22:49AM -0400, Robert Haas wrote: > > Committed. I removed the changes from the .po files since we don't > > routinely update those, and I rewrote your proposal commit message. > > nitpick: It looks like this needs

Re: Better HINT message for "unexpected data beyond EOF"

2025-07-28 Thread Nathan Bossart
On Mon, Jul 28, 2025 at 11:22:49AM -0400, Robert Haas wrote: > Committed. I removed the changes from the .po files since we don't > routinely update those, and I rewrote your proposal commit message. nitpick: It looks like this needs a pgindent [0]. [0] https://buildfarm.postgresql.org/cgi-bin/s

Re: Better HINT message for "unexpected data beyond EOF"

2025-07-28 Thread Robert Haas
On Mon, May 26, 2025 at 7:40 AM Jakub Wartak wrote: > v2 attached, rebased and tested. Committed. I removed the changes from the .po files since we don't routinely update those, and I rewrote your proposal commit message. -- Robert Haas EDB: http://www.enterprisedb.com

Re: Better HINT message for "unexpected data beyond EOF"

2025-05-26 Thread Jakub Wartak
On Fri, Apr 4, 2025 at 12:55 PM Jakub Wartak wrote: Hi [..] > OK, so attached is a small patch to eradicate this HINT: CI tested, > verified using original reproducer, registered in cf app. v2 attached, rebased and tested. -J. v2-0001-Remove-HINT-message-for-unexpected-data-beyond-EO.patch Des

Re: Better HINT message for "unexpected data beyond EOF"

2025-04-05 Thread Robert Haas
On Thu, Mar 27, 2025 at 10:12 AM Andres Freund wrote: > FWIW, I think we should just drop the HINT. We really have no clue what caused > it and a HINT should imo have at least some value other than "*Shrug*", which > is imo pretty much what these HINTs amount to, if they were a bit more blunt. I

Re: Better HINT message for "unexpected data beyond EOF"

2025-04-04 Thread Jakub Wartak
On Tue, Apr 1, 2025 at 3:59 PM Andres Freund wrote: Hi Robert, Andres, Christoph, > On 2025-04-01 09:49:12 -0400, Robert Haas wrote: > > On Tue, Apr 1, 2025 at 7:13 AM Jakub Wartak > > wrote: > > > Thread bump. So we have the following candidates: > > > > > > 1. remove it as Andres stated: > >

Re: Better HINT message for "unexpected data beyond EOF"

2025-04-01 Thread Andres Freund
Hi, On 2025-04-01 09:49:12 -0400, Robert Haas wrote: > On Tue, Apr 1, 2025 at 7:13 AM Jakub Wartak > wrote: > > Thread bump. So we have the following candidates: > > > > 1. remove it as Andres stated: > > ERROR: unexpected data beyond EOF in block 1472 of relation base/5/16387 > > > > 2a. Robert

Re: Better HINT message for "unexpected data beyond EOF"

2025-04-01 Thread Christoph Berg
Re: Robert Haas > > Another question is should we back-patch this? I believe we should (?) > > I don't think this qualifies as a bug. The current wording isn't > factually wrong, just unhelpful. Even if it were wrong, we need a > pretty good reason to change message strings in a stable branch, > b

Re: Better HINT message for "unexpected data beyond EOF"

2025-04-01 Thread Robert Haas
On Tue, Apr 1, 2025 at 9:54 AM Christoph Berg wrote: > Re: Robert Haas > > > Another question is should we back-patch this? I believe we should (?) > > I don't think this qualifies as a bug. The current wording isn't > > factually wrong, just unhelpful. Even if it were wrong, we need a > > pretty

Re: Better HINT message for "unexpected data beyond EOF"

2025-04-01 Thread Robert Haas
On Tue, Apr 1, 2025 at 7:13 AM Jakub Wartak wrote: > Thread bump. So we have the following candidates: > > 1. remove it as Andres stated: > ERROR: unexpected data beyond EOF in block 1472 of relation base/5/16387 > > 2a. Robert's idea > ERROR: unexpected data beyond EOF in block 1472 of relation

Re: Better HINT message for "unexpected data beyond EOF"

2025-04-01 Thread Jakub Wartak
On Thu, Mar 27, 2025 at 4:00 PM Christoph Berg wrote: > > Re: Robert Haas > > I think that would be better than what we have now, but I still wonder > > if we should give some kind of a hint that an external process may be > > doing something to that file. Jakub and I may be biased by having just

Re: Better HINT message for "unexpected data beyond EOF"

2025-03-27 Thread Christoph Berg
Re: Robert Haas > I think that would be better than what we have now, but I still wonder > if we should give some kind of a hint that an external process may be > doing something to that file. Jakub and I may be biased by having just > seen a case of exactly that in the field, but I wonder now how

Re: Better HINT message for "unexpected data beyond EOF"

2025-03-27 Thread Andres Freund
Hi, On 2025-03-27 10:25:50 +0100, Jakub Wartak wrote: > On Wed, Mar 26, 2025 at 4:01 PM Robert Haas wrote: > [..] > > > so how about: > > > -HINT: This has been seen to occur with buggy kernels; consider > > > updating your system. > > > +HINT: This has been observed with files being overwritte

Re: Better HINT message for "unexpected data beyond EOF"

2025-03-27 Thread Jakub Wartak
On Wed, Mar 26, 2025 at 4:01 PM Robert Haas wrote: [..] > > so how about: > > -HINT: This has been seen to occur with buggy kernels; consider > > updating your system. > > +HINT: This has been observed with files being overwritten, buggy > > kernels and potentially other external file system inf

Re: Better HINT message for "unexpected data beyond EOF"

2025-03-26 Thread Robert Haas
On Wed, Mar 26, 2025 at 4:59 AM Jakub Wartak wrote: > ERROR: unexpected data beyond EOF in block 1472 of relation base/5/16387 > HINT: This has been seen to occur with buggy kernels; consider > updating your system. > > to something more generic and less confusing. It is coming from > ffae5cc5a6

Better HINT message for "unexpected data beyond EOF"

2025-03-26 Thread Jakub Wartak
I would like to propose that we tweak the following error message: ERROR: unexpected data beyond EOF in block 1472 of relation base/5/16387 HINT: This has been seen to occur with buggy kernels; consider updating your system. to something more generic and less confusing. It is coming from ffae5c