Re: BUG #18815: Logical replication worker Segmentation fault

2025-04-09 Thread Amit Kapila
On Tue, Apr 8, 2025 at 12:26 PM Zhijie Hou (Fujitsu) wrote: > > > I am attaching the V2 patch which implements this idea by > postponing index info initialization until the FindConflictTuple(). I > confirmed > It can pass regression and pgindent check. > Thanks, I pushed this patch yesterday. -

Re: BUG #18815: Logical replication worker Segmentation fault

2025-04-08 Thread Amit Kapila
On Mon, Apr 7, 2025 at 3:28 PM Zhijie Hou (Fujitsu) wrote: > > > What is the > > behavior of conflict reporting code in case of exclusion constraints? > > Under logical replication context, since we do not detect conflicts for > exclusion > constraints, it would simply report the original constra

RE: BUG #18815: Logical replication worker Segmentation fault

2025-04-07 Thread Zhijie Hou (Fujitsu)
On Tue, Apr 8, 2025 at 2:00 PM Amit Kapila wrote: > > On Mon, Apr 7, 2025 at 3:28 PM Zhijie Hou (Fujitsu) > wrote: > > > > > What is the > > > behavior of conflict reporting code in case of exclusion constraints? > > > > Under logical replication context, since we do not detect conflicts > > for

RE: BUG #18815: Logical replication worker Segmentation fault

2025-04-07 Thread Zhijie Hou (Fujitsu)
On Mon, Apr 7, 2025 at 5:37 PM Amit Kapila wrote: > > On Wed, Mar 26, 2025 at 10:3 AM Zhijie Hou (Fujitsu) > wrote: > > > > On Wed, Feb 19, 2025 at 4:38 AM Tom Lane wrote: > > > > My colleague Nisha reported off-list about a crash in logical replication > > that > > occurs during unique constra

Re: BUG #18815: Logical replication worker Segmentation fault

2025-04-07 Thread Amit Kapila
On Wed, Mar 26, 2025 at 10:38 AM Zhijie Hou (Fujitsu) wrote: > > On Wed, Feb 19, 2025 at 4:38 AM Tom Lane wrote: > > My colleague Nisha reported off-list about a crash in logical replication that > occurs during unique constraint violations on leaf partitions. Upon > investigation, I confirmed tha

RE: BUG #18815: Logical replication worker Segmentation fault

2025-03-25 Thread Zhijie Hou (Fujitsu)
On Wed, Feb 19, 2025 at 4:38 AM Tom Lane wrote: Hi, > > Here's a completed set of patches for bug #18815 [1] (which, briefly, > is that the logrep worker opens/closes indexes multiple times and > thereby breaks brininsertcleanup). > > 0001 adds a subscriber-side BRIN index to 013_partition.pl

Re: BUG #18815: Logical replication worker Segmentation fault

2025-02-20 Thread Sergey Belyashov
I have applied the patch. Replication now works. Thank you. Regards чт, 20 февр. 2025 г. в 00:55, Tom Lane : > > Sergey Belyashov writes: > > The 4th patch is not applicable for the current REL_17_STABLE branch. > > There are a lot of differences from master in the worker.c. > > If you want to t

Re: BUG #18815: Logical replication worker Segmentation fault

2025-02-19 Thread Tom Lane
Sergey Belyashov writes: > The 4th patch is not applicable for the current REL_17_STABLE branch. > There are a lot of differences from master in the worker.c. If you want to try the committed v17 patch, see https://git.postgresql.org/gitweb/?p=postgresql.git;a=patch;h=788baa9a25ae83b576621166367

Re: BUG #18815: Logical replication worker Segmentation fault

2025-02-18 Thread Tom Lane
Sergey Belyashov writes: > The 4th patch is not applicable for the current REL_17_STABLE branch. Yeah, I saw that, didn't work on fixing it yet. It looked like the diffs were mostly about the ExecOpen/CloseIndices calls in apply_handle_tuple_routing, which we already knew are completely bogus.

Re: BUG #18815: Logical replication worker Segmentation fault

2025-02-18 Thread Sergey Belyashov
Hi, The 4th patch is not applicable for the current REL_17_STABLE branch. There are a lot of differences from master in the worker.c. Best regards, Sergey Belyashov ср, 19 февр. 2025 г. в 01:24, Tom Lane : > > I wrote: > > I don't intend 0003 for back-patch, but the rest of this has to go > > ba

Re: BUG #18815: Logical replication worker Segmentation fault

2025-02-18 Thread Tom Lane
I wrote: > I don't intend 0003 for back-patch, but the rest of this has to go > back as far as the bug can be observed, which I didn't test yet. Ah: this bug is new in v17, because neither brininsertcleanup nor the whole aminsertcleanup infrastructure exist before that. So that leaves us with a q

Re: BUG #18815: Logical replication worker Segmentation fault

2025-02-18 Thread Tom Lane
[ redirecting to -hackers for patch discussion ] Here's a completed set of patches for bug #18815 [1] (which, briefly, is that the logrep worker opens/closes indexes multiple times and thereby breaks brininsertcleanup). 0001 adds a subscriber-side BRIN index to 013_partition.pl, which replicates