Re: BUG #18059: Unexpected error 25001 in stored procedure

2023-08-23 Thread Tom Lane
I wrote: > I started to code this, and immediately noticed that transformStmt() > already has a companion function analyze_requires_snapshot() that > returns "true" in the cases of interest ... except that it does > not return true for T_CallStmt. Perhaps that was intentional to > begin with, but

Re: BUG #18059: Unexpected error 25001 in stored procedure

2023-08-22 Thread Tom Lane
Robert Haas writes: > On Sat, Aug 19, 2023 at 1:19 PM Tom Lane wrote: >> What I'm inclined to propose, therefore, is that we make revalidation >> be a no-op for every statement type for which transformStmt() reaches >> its default: case. (When it does so, the resulting CMD_UTILITY Query >> will

Re: BUG #18059: Unexpected error 25001 in stored procedure

2023-08-21 Thread Robert Haas
On Sat, Aug 19, 2023 at 1:19 PM Tom Lane wrote: > What I'm inclined to propose, therefore, is that we make revalidation > be a no-op for every statement type for which transformStmt() reaches > its default: case. (When it does so, the resulting CMD_UTILITY Query > will not get any processing from

Re: BUG #18059: Unexpected error 25001 in stored procedure

2023-08-19 Thread Tom Lane
[ redirected to -hackers ] PG Bug reporting form writes: > Steps to reproduce: > 1. Create stored procedure > create or replace procedure test_proc() > language plpgsql as $procedure$ > begin >commit; >set transaction isolation level repeatable read; >-- here follows some useful code