Re: BAS_BULKREAD vs read stream

2025-04-10 Thread Thomas Munro
On Tue, Apr 8, 2025 at 2:20 PM Andres Freund wrote: > In the attached I implemented the above idea, with some small additional > refinements: LGTM. How I wish EXPLAIN would show some clues about strategies...

Re: BAS_BULKREAD vs read stream

2025-04-08 Thread Andres Freund
Hi, On 2025-04-08 18:11:04 +1200, Thomas Munro wrote: > On Tue, Apr 8, 2025 at 2:20 PM Andres Freund wrote: > > In the attached I implemented the above idea, with some small additional > > refinements: > > LGTM. Thanks for checking. > How I wish EXPLAIN would show some clues about strategies.

Re: BAS_BULKREAD vs read stream

2025-04-08 Thread Jakub Wartak
On Sun, Apr 6, 2025 at 10:15 PM Andres Freund wrote: > > Hi, [..] > The obvious solution to that would be to increase BAS_BULKREAD substantially > above 256kB. > > For quite a while was worried about increasing the size, because somewhere (I > couldn't find it while writing this email, will add th

Re: BAS_BULKREAD vs read stream

2025-04-07 Thread Andres Freund
Hi, On 2025-04-07 16:28:20 -0400, Andres Freund wrote: > On 2025-04-07 15:24:43 -0400, Melanie Plageman wrote: > > On Sun, Apr 6, 2025 at 4:15 PM Andres Freund wrote: > > > > > > I think we should consider increasing BAS_BULKREAD TO something like > > > Min(256, io_combine_limit * (effective_io

Re: BAS_BULKREAD vs read stream

2025-04-07 Thread Melanie Plageman
On Sun, Apr 6, 2025 at 4:15 PM Andres Freund wrote: > > I think we should consider increasing BAS_BULKREAD TO something like > Min(256, io_combine_limit * (effective_io_concurrency + 1)) Do you mean Max? If so, this basically makes sense to me. Overall, I think even though the ring is about reu

Re: BAS_BULKREAD vs read stream

2025-04-07 Thread Andres Freund
Hi, On 2025-04-07 15:24:43 -0400, Melanie Plageman wrote: > On Sun, Apr 6, 2025 at 4:15 PM Andres Freund wrote: > > > > I think we should consider increasing BAS_BULKREAD TO something like > > Min(256, io_combine_limit * (effective_io_concurrency + 1)) > > Do you mean Max? If so, this basically

BAS_BULKREAD vs read stream

2025-04-06 Thread Andres Freund
Hi, There are two issues with BAS_BULKREAD interactions with read stream. One for 17+ and one for 18+. The 17+ issue: While trying to analyze issues with BAS_BULKREAD's size vs AIO I was getting really confusing results. After an embarassingly long time I figured out that a good chunk of those