On 2021/09/08 23:40, Fujii Masao wrote:
Agreed. Since it's hard to imagine the issue happens in practice,
we don't need to bother back-patch to the stable branches.
So I'm thinking to commit the patch to 15dev and 14.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Ce
On 2021/09/07 18:24, Fabien COELHO wrote:
Hello Fujii-san,
Stop counting skipped transactions under -T as soon as the timer is exceeded.
Because otherwise it can take a very long time to count all of them especially
when quite a lot of them happen with unrealistically high rate setting in
Hello Fujii-san,
Stop counting skipped transactions under -T as soon as the timer is
exceeded. Because otherwise it can take a very long time to count all of
them especially when quite a lot of them happen with unrealistically
high rate setting in -R, which would prevent pgbench from ending
On 2021/09/04 15:27, Fabien COELHO wrote:
Hello Fujii-san,
ISTM that the patch changes pgbench so that it can skip counting
some skipped transactions here even for realistic rates under -T.
Of course, which would happen very rarely. Is this understanding right?
Yes. The point is to get ou
Hello Fujii-san,
ISTM that the patch changes pgbench so that it can skip counting
some skipped transactions here even for realistic rates under -T.
Of course, which would happen very rarely. Is this understanding right?
Yes. The point is to get out of the scheduling loop when time has expire
On 2021/06/17 1:23, Yugo NAGATA wrote:
I attached the v2 patch to clarify that I withdrew the v3 patch.
Thanks for the patch!
+* For very unrealistic
rates under -T, some skipped
+
On Tue, 10 Aug 2021 10:50:20 -0400
Greg Sabino Mullane wrote:
> Apologies, just saw this. I found no problems, those "failures" were just
> me missing checkboxes on the commitfest interface. +1 on the patch.
Thank you!
--
Yugo NAGATA
Apologies, just saw this. I found no problems, those "failures" were just
me missing checkboxes on the commitfest interface. +1 on the patch.
Cheers,
Greg
Hello Greg,
On Tue, 22 Jun 2021 19:22:38 +
Greg Sabino Mullane wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, failed
> Implements feature: tested, failed
> Spec compliant: not tested
> Documentation:
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: not tested
Documentation:not tested
Looks fine to me, as a way of catching this edge case.
On Mon, 14 Jun 2021 16:06:10 +0900
Yugo NAGATA wrote:
> On Mon, 14 Jun 2021 08:47:40 +0200 (CEST)
> Fabien COELHO wrote:
> > > I attached the fixed patch that uses return instead of break, and I
> > > confirmed
> > > that this made the progress reporting work property.
> >
> > I'm hesitating
On Mon, 14 Jun 2021 08:47:40 +0200 (CEST)
Fabien COELHO wrote:
>
> >>> I attached a patch for this fix.
> >>
> >> The patch mostly works for me, and I agree that the bench should not be in
> >> a loop on any parameters, even when "crazy" parameters are given…
> >>
> >> However I'm not sure this
I attached a patch for this fix.
The patch mostly works for me, and I agree that the bench should not be in
a loop on any parameters, even when "crazy" parameters are given…
However I'm not sure this is the right way to handle this issue.
The catch-up loop can be dropped and the automaton ca
Hello Fabien,
On Sun, 13 Jun 2021 08:56:59 +0200 (CEST)
Fabien COELHO wrote:
> > I attached a patch for this fix.
>
> The patch mostly works for me, and I agree that the bench should not be in
> a loop on any parameters, even when "crazy" parameters are given…
>
> However I'm not sure this is
Hello Yugo-san,
For example, when I usee a large rate (-R) for throttling and a
small latency limit (-L) values with a duration (-T), pbbench
got stuck.
$ pgbench -T 5 -R 1 -L 1;
Indeed, it does not get out of the catchup loop for a long time because
even scheduling takes more time
Hi,
I found that pgbench could get stuck when every transaction
come to be skipped and the number of transaction is not limitted
by -t option.
For example, when I usee a large rate (-R) for throttling and a
small latency limit (-L) values with a duration (-T), pbbench
got stuck.
$ pgbench -T 5
16 matches
Mail list logo
