RE: Avoid retaining conflict-related data when no tables are subscribed

2025-09-05 Thread Zhijie Hou (Fujitsu)
On Thursday, September 4, 2025 7:38 PM Amit Kapila wrote: > > On Tue, Sep 2, 2025 at 10:51 AM Zhijie Hou (Fujitsu) > wrote: > > > > On Friday, August 29, 2025 12:05 PM Amit Kapila > wrote: > > > > > > bool > > > -AllTablesyncsReady(void) > > > +AllTablesyncsReady(bool ready_if_no_tables) > >

Re: Avoid retaining conflict-related data when no tables are subscribed

2025-09-04 Thread Amit Kapila
On Tue, Sep 2, 2025 at 10:51 AM Zhijie Hou (Fujitsu) wrote: > > On Friday, August 29, 2025 12:05 PM Amit Kapila > wrote: > > > > bool > > -AllTablesyncsReady(void) > > +AllTablesyncsReady(bool ready_if_no_tables) > > > > This change serves the purpose but I find it makes the API complex to > >

RE: Avoid retaining conflict-related data when no tables are subscribed

2025-09-02 Thread Zhijie Hou (Fujitsu)
On Friday, August 29, 2025 12:05 PM Amit Kapila wrote: > > On Thu, Aug 28, 2025 at 7:54 AM Zhijie Hou (Fujitsu) > wrote: > > > > Hi, > > > > My colleague Nisha reported an issue to me off-list: dead tuples can't > > be removed when retain_dead_tuples is enabled for a subscription with no > table

Re: Avoid retaining conflict-related data when no tables are subscribed

2025-08-28 Thread Amit Kapila
On Thu, Aug 28, 2025 at 7:54 AM Zhijie Hou (Fujitsu) wrote: > > Hi, > > My colleague Nisha reported an issue to me off-list: dead tuples can't > be removed when retain_dead_tuples is enabled for a subscription with no > tables. > > This appears to stem from the inability to advance the non-remova

Re: Avoid retaining conflict-related data when no tables are subscribed

2025-08-28 Thread Nisha Moond
On Thu, Aug 28, 2025 at 7:54 AM Zhijie Hou (Fujitsu) wrote: > > Hi, > > My colleague Nisha reported an issue to me off-list: dead tuples can't > be removed when retain_dead_tuples is enabled for a subscription with no > tables. > > This appears to stem from the inability to advance the non-remova

Re: Avoid retaining conflict-related data when no tables are subscribed

2025-08-27 Thread Steven Niu
Just a typo: +* it seem feasible to skip all phases and directly assign Should be "it seems". Regards, Steven 在 2025/8/28 10:23, Zhijie Hou (Fujitsu) 写道: Hi, My colleague Nisha reported an issue to me off-list: dead tuples can't be removed when retain_dead_tuples is enabled for a s

Re: Avoid retaining conflict-related data when no tables are subscribed

2025-08-27 Thread shveta malik
On Thu, Aug 28, 2025 at 7:54 AM Zhijie Hou (Fujitsu) wrote: > > Hi, > > My colleague Nisha reported an issue to me off-list: dead tuples can't > be removed when retain_dead_tuples is enabled for a subscription with no > tables. > > This appears to stem from the inability to advance the non-remova

Re: Avoid retaining conflict-related data when no tables are subscribed

2025-08-27 Thread Dilip Kumar
On Thu, Aug 28, 2025 at 7:54 AM Zhijie Hou (Fujitsu) wrote: > > Hi, > > My colleague Nisha reported an issue to me off-list: dead tuples can't > be removed when retain_dead_tuples is enabled for a subscription with no > tables. > > This appears to stem from the inability to advance the non-remova

Avoid retaining conflict-related data when no tables are subscribed

2025-08-27 Thread Zhijie Hou (Fujitsu)
Hi, My colleague Nisha reported an issue to me off-list: dead tuples can't be removed when retain_dead_tuples is enabled for a subscription with no tables. This appears to stem from the inability to advance the non-removable transaction ID when AllTablesyncsReady() returns false. Since this funct