Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)

2024-09-05 Thread Ranier Vilela
Em qui., 5 de set. de 2024 às 10:39, Daniel Gustafsson escreveu: > > On 4 Sep 2024, at 20:35, Daniel Gustafsson wrote: > >> On 4 Sep 2024, at 19:30, Nathan Bossart > wrote: > >> On Wed, Sep 04, 2024 at 02:10:28PM -0300, Ranier Vilela wrote: > > >>> patch attached. > >> > >> Yeah, that looks lik

Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)

2024-09-05 Thread Daniel Gustafsson
> On 4 Sep 2024, at 20:35, Daniel Gustafsson wrote: >> On 4 Sep 2024, at 19:30, Nathan Bossart wrote: >> On Wed, Sep 04, 2024 at 02:10:28PM -0300, Ranier Vilela wrote: >>> patch attached. >> >> Yeah, that looks like a problem to me. I've cc'd Daniel here. > > Thanks for the report, it does se

Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)

2024-09-04 Thread Daniel Gustafsson
> On 4 Sep 2024, at 19:30, Nathan Bossart wrote: > > On Wed, Sep 04, 2024 at 02:10:28PM -0300, Ranier Vilela wrote: >> I think that commit 6ebeeae >> left out an oversight. >> >> The report is: >> CID 1559991: (#1 of 1): Dereference null return v

Re: Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)

2024-09-04 Thread Nathan Bossart
On Wed, Sep 04, 2024 at 02:10:28PM -0300, Ranier Vilela wrote: > I think that commit 6ebeeae > left out an oversight. > > The report is: > CID 1559991: (#1 of 1): Dereference null return value (NULL_RETURNS) > > The function *findTypeByOid* can re

Avoid possible dereference null pointer (src/bin/pg_dump/pg_dump.c)

2024-09-04 Thread Ranier Vilela
Hi. Per Coverity. I think that commit 6ebeeae left out an oversight. The report is: CID 1559991: (#1 of 1): Dereference null return value (NULL_RETURNS) The function *findTypeByOid* can return NULL. It is necessary to check the function's return