Re: Avoid choose invalid number of partitions (src/backend/executor/nodeAgg.c)

2021-08-30 Thread Ranier Vilela
Em seg., 30 de ago. de 2021 às 07:44, David Rowley escreveu: > On Wed, 30 Jun 2021 at 02:33, Ranier Vilela wrote: > > hash_choose_num_partitions function has issues. > > There are at least two path calls made with used_bits = 0. > > See at hashagg_spill_init. > > > On Windows 64 bits (HEAD) fail

Re: Avoid choose invalid number of partitions (src/backend/executor/nodeAgg.c)

2021-08-30 Thread David Rowley
On Wed, 30 Jun 2021 at 02:33, Ranier Vilela wrote: > hash_choose_num_partitions function has issues. > There are at least two path calls made with used_bits = 0. > See at hashagg_spill_init. > On Windows 64 bits (HEAD) fails with partition_prune: > parallel group (11 tests): reloptions hash_part

Avoid choose invalid number of partitions (src/backend/executor/nodeAgg.c)

2021-06-29 Thread Ranier Vilela
Hi, Not per Coverity. hash_choose_num_partitions function has issues. There are at least two path calls made with used_bits = 0. See at hashagg_spill_init. To confirm, I run this code on cpp.sh: int main() { int npartitions = 0; int used_bits = 0; int partition_bits = 0; int i; f