On Wed, Jun 30, 2021 at 8:56 PM Gurjeet Singh wrote:
> As mentioned in that thread, when sending a cancellation signal, the
> client cannot be sure if the cancel signal was honored, and if the
> transaction was cancelled successfully. In the attached patch, the
> backend emits a NotificationRespon
> On 22 Jul 2021, at 07:28, vignesh C wrote:
>
> On Thu, Jul 1, 2021 at 6:41 AM Gurjeet Singh wrote:
>>
>> The proposed patch is attached.
>
> There is one compilation warning:
> xid.c:165:1: warning: no previous prototype for
> ‘FullTransactionIdToStr’ [-Wmissing-prototypes]
> 165 | FullTran
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Hello
This patch applies fine to master branch and the regre
Greetings,
I simply tested it and it works well. But I got a compilation warning,
should we move the definition of function FullTransactionIdToStr to the
"transam.h"?
--
There is no royal road to learning.
HighGo Software Co.
On Thu, Jul 1, 2021 at 6:41 AM Gurjeet Singh wrote:
>
> The proposed patch is attached.
There is one compilation warning:
xid.c:165:1: warning: no previous prototype for
‘FullTransactionIdToStr’ [-Wmissing-prototypes]
165 | FullTransactionIdToStr(FullTransactionId fxid)
| ^~~~
The proposed patch is attached.
Best regards,
--
Gurjeet Singh http://gurjeet.singh.im/
On Wed, Jun 30, 2021 at 5:56 PM Gurjeet Singh wrote:
>
> (Re-sending this email, because the Commitfest app mistakenly [3]
> considered previous email [4] to be part of the old thread, whereas it
> should not
(Re-sending this email, because the Commitfest app mistakenly [3]
considered previous email [4] to be part of the old thread, whereas it
should not be considered that way)
I came across this thread [1] to disallow canceling a transaction not
yet confirmed by a synchronous replica. I think my propo
