Re: Augment every test postgresql.conf

2019-05-12 Thread Noah Misch
On Sat, May 11, 2019 at 10:43:59PM -0400, Tom Lane wrote: > Noah Misch writes: > > Pushed. This broke 010_dump_connstr.pl on bowerbird, introducing 'invalid > > byte sequence for encoding "UTF8"' errors. That's because log_connections > > renders this 010_dump_connstr.pl solution insufficient: >

Re: Augment every test postgresql.conf

2019-05-11 Thread Tom Lane
Noah Misch writes: > Pushed. This broke 010_dump_connstr.pl on bowerbird, introducing 'invalid > byte sequence for encoding "UTF8"' errors. That's because log_connections > renders this 010_dump_connstr.pl solution insufficient: Ugh. > 4. If GetMessageEncoding()==PG_SQL_ASCII, make pgwin32_mes

Re: Augment every test postgresql.conf

2019-05-11 Thread Noah Misch
On Sun, Apr 07, 2019 at 07:56:02AM -0400, Andrew Dunstan wrote: > On Sun, Apr 7, 2019 at 2:41 AM Noah Misch wrote: > > > > On Sun, Dec 30, 2018 at 10:32:31AM -0500, Andrew Dunstan wrote: > > > On 12/30/18 12:53 AM, Noah Misch wrote: > > > > 2. stats_temp_directory is incompatible with TAP suites t

Re: Augment every test postgresql.conf

2019-04-07 Thread Andrew Dunstan
On Sun, Apr 7, 2019 at 2:41 AM Noah Misch wrote: > > On Sun, Dec 30, 2018 at 10:32:31AM -0500, Andrew Dunstan wrote: > > On 12/30/18 12:53 AM, Noah Misch wrote: > > > 2. stats_temp_directory is incompatible with TAP suites that start more > > > than > > >one node simultaneously. > > > The obv

Re: Augment every test postgresql.conf

2019-04-06 Thread Noah Misch
On Sun, Dec 30, 2018 at 10:32:31AM -0500, Andrew Dunstan wrote: > On 12/30/18 12:53 AM, Noah Misch wrote: > > 2. stats_temp_directory is incompatible with TAP suites that start more than > >one node simultaneously. > The obvious quick fix would be to have PostgresNode.pm set this to the > defa

Re: Augment every test postgresql.conf

2018-12-30 Thread Andrew Dunstan
On 12/30/18 12:53 AM, Noah Misch wrote: > On Sat, Dec 29, 2018 at 10:46:31PM -0500, Tom Lane wrote: >> Noah Misch writes: >>> Looking more closely, we already have the TEMP_CONFIG variable and apply it >>> to >>> everything except TAP suites. Closing that gap, as attached, is enough. >>> The

Re: Augment every test postgresql.conf

2018-12-29 Thread Noah Misch
On Sat, Dec 29, 2018 at 10:46:31PM -0500, Tom Lane wrote: > Noah Misch writes: > > Looking more closely, we already have the TEMP_CONFIG variable and apply it > > to > > everything except TAP suites. Closing that gap, as attached, is enough. > > The > > buildfarm client uses TEMP_CONFIG to imp

Re: Augment every test postgresql.conf

2018-12-29 Thread Tom Lane
Noah Misch writes: > Looking more closely, we already have the TEMP_CONFIG variable and apply it to > everything except TAP suites. Closing that gap, as attached, is enough. The > buildfarm client uses TEMP_CONFIG to implement its extra_config setting, so > this will cause extra_config to start

Re: Augment every test postgresql.conf

2018-12-29 Thread Noah Misch
On Fri, Dec 28, 2018 at 06:19:50PM -0800, Noah Misch wrote: > "env EXTRA_REGRESS_OPTS=--temp-config=SOMEFILE make check" appends the > contents of SOMEFILE to the test cluster's postgresql.conf. I want a similar > feature for TAP suites and other non-pg_regress suites. (My immediate use > case is

Augment every test postgresql.conf

2018-12-28 Thread Noah Misch
"env EXTRA_REGRESS_OPTS=--temp-config=SOMEFILE make check" appends the contents of SOMEFILE to the test cluster's postgresql.conf. I want a similar feature for TAP suites and other non-pg_regress suites. (My immediate use case is to raise authentication_timeout and wal_sender_timeout on my buildf