Re: AtEOXact_ApplyLauncher() and subtransactions

2018-07-17 Thread Amit Khandekar
On 17 July 2018 at 03:29, Robert Haas wrote: > On Mon, Jul 16, 2018 at 2:36 AM, Amit Khandekar > wrote: >> 0001 patch contains the main fix. In this patch I have used some >> naming conventions and some comments that you used in your patch, >> plus, I used your method of lazily allocating new st

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-07-16 Thread Robert Haas
On Mon, Jul 16, 2018 at 2:36 AM, Amit Khandekar wrote: > 0001 patch contains the main fix. In this patch I have used some > naming conventions and some comments that you used in your patch, > plus, I used your method of lazily allocating new stack level. The > stack is initially Null. Committed a

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-07-15 Thread Amit Khandekar
On Thu, 5 Jul 2018 at 3:37 PM, Amit Khandekar wrote: > > On 4 July 2018 at 00:27, Robert Haas wrote: > > On Tue, Jun 26, 2018 at 6:25 AM, Amit Khandekar > > wrote: > >> Added this into the July 2018 commitfest : > >> > >> https://commitfest.postgresql.org/18/1696/ > > > > It seems to me that it

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-07-05 Thread Amit Khandekar
On 4 July 2018 at 00:27, Robert Haas wrote: > On Tue, Jun 26, 2018 at 6:25 AM, Amit Khandekar > wrote: >> Added this into the July 2018 commitfest : >> >> https://commitfest.postgresql.org/18/1696/ > > It seems to me that it would probably be better to separate this into > two patches, because I

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-07-03 Thread Robert Haas
On Tue, Jun 26, 2018 at 6:25 AM, Amit Khandekar wrote: > Added this into the July 2018 commitfest : > > https://commitfest.postgresql.org/18/1696/ It seems to me that it would probably be better to separate this into two patches, because I think there are really two separate issues. With regard t

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-06-26 Thread Amit Khandekar
Added this into the July 2018 commitfest : https://commitfest.postgresql.org/18/1696/ On 20 June 2018 at 22:22, Amit Khandekar wrote: > On 18 June 2018 at 15:02, Amit Khandekar wrote: >> On 16 June 2018 at 00:03, Amit Khandekar wrote: >>> The way I am implementing this can be seen in attached

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-06-20 Thread Amit Khandekar
On 18 June 2018 at 15:02, Amit Khandekar wrote: > On 16 June 2018 at 00:03, Amit Khandekar wrote: >> The way I am implementing this can be seen in attached >> apply_launcher_subtrans_WIP.patch. (check launcher.c changes). I >> haven't started testing it yet though. > > Attached patch passes some

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-06-18 Thread Amit Khandekar
On 16 June 2018 at 00:03, Amit Khandekar wrote: > The way I am implementing this can be seen in attached > apply_launcher_subtrans_WIP.patch. (check launcher.c changes). I > haven't started testing it yet though. Attached patch passes some basic testing I did. Will do some more testing, and some

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-06-15 Thread Amit Khandekar
On 15 June 2018 at 09:46, Peter Eisentraut wrote: > On 6/5/18 07:02, Amit Khandekar wrote: >> I haven't written a patch for it, but I think we should have a >> separate on_commit_stop_workers for eachyou get subtransaction. At >> subtransaction commit, we replace the on_commit_stop_workers list of

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-06-14 Thread Peter Eisentraut
On 6/5/18 07:02, Amit Khandekar wrote: > I haven't written a patch for it, but I think we should have a > separate on_commit_stop_workers for eachyou get subtransaction. At > subtransaction commit, we replace the on_commit_stop_workers list of > the parent subtransaction with the one from the commi

Re: AtEOXact_ApplyLauncher() and subtransactions

2018-06-14 Thread Alvaro Herrera
On 2018-Jun-05, Amit Khandekar wrote: > When a SUBSCRIPTION is altered, then the currently running > table-synchronization workers that are no longer needed for the > altered subscription, are terminated. This is done by the function > AtEOXact_ApplyLauncher() inside CommitTransaction(). So during

AtEOXact_ApplyLauncher() and subtransactions

2018-06-05 Thread Amit Khandekar
Hi, When a SUBSCRIPTION is altered, then the currently running table-synchronization workers that are no longer needed for the altered subscription, are terminated. This is done by the function AtEOXact_ApplyLauncher() inside CommitTransaction(). So during each ALTER-SUBSCRIPTION command, the on_c