Re: Asymmetry in opening and closing indices for partition routing

2020-06-29 Thread Ashutosh Bapat
On Mon, 22 Jun 2020 at 23:22, Alvaro Herrera wrote: > > I'm not sure that expecting the relcache entry's refcount drops to zero > at the right time is a good approach; that may cause leaks some other > place might have refcounts you're not expecting (say, an open cursor > that's not fully read).

Re: Asymmetry in opening and closing indices for partition routing

2020-06-22 Thread Alvaro Herrera
Hi Ashutosh, On 2020-Jun-22, Ashutosh Bapat wrote: > I couldn't find code where this can happen but I don't see any code which > prevents this. This looks like a recipe for memory and reference leaks. > > We could fix this by > 1. Make ExecOpenIndices and ExecCloseIndices so that they can be cal

Asymmetry in opening and closing indices for partition routing

2020-06-22 Thread Ashutosh Bapat
Hi All, ExecInitPartitionInfo() has code 536 /* 537 * Open partition indices. The user may have asked to check for conflicts 538 * within this leaf partition and do "nothing" instead of throwing an 539 * error. Be prepared in that case by initializing the index information