Re: Assertion failure with barriers in parallel hash join

2023-03-20 Thread Thomas Munro
Pushed and back-patched, with minor comment tweaks. Apologies for taking so long.

Re: Assertion failure with barriers in parallel hash join

2022-11-18 Thread David Geier
Thanks! Please let me know if I can help out, e.g. with re-testing. -- David Geier (ServiceNow) On 11/17/22 08:28, Thomas Munro wrote: On Thu, Nov 17, 2022 at 8:01 PM David Geier wrote: Can we make progress with this patch in the current commit fest, or discuss what is still missing to brin

Re: Assertion failure with barriers in parallel hash join

2022-11-16 Thread Thomas Munro
On Thu, Nov 17, 2022 at 8:01 PM David Geier wrote: > Can we make progress with this patch in the current commit fest, or discuss > what is still missing to bring this in? Hi David, Sorry for the delay. I'll aim to get this done in the next few days.

Re: Assertion failure with barriers in parallel hash join

2022-11-16 Thread David Geier
Hi Thomas, Can we make progress with this patch in the current commit fest, or discuss what is still missing to bring this in? Thanks! -- David Geier (ServiceNow) On 6/6/22 17:01, David Geier wrote: Hi Thomas, Correct. We're running with disabled parallel leader participation and we have

Re: Assertion failure with barriers in parallel hash join

2022-06-06 Thread David Geier
Hi Thomas, Correct. We're running with disabled parallel leader participation and we have to do so, because another custom plan node we built relies on that. That would be great. Anything else I can help with to get this patch in? Thanks! -- David (ServiceNow) On Fri, 3 Jun 2022 at 00:06, Thoma

Re: Assertion failure with barriers in parallel hash join

2022-06-02 Thread Thomas Munro
On Thu, Jun 2, 2022 at 9:31 PM David Geier wrote: > We recently encountered the same bug in the field. Oleksii Kozlov managed to > come up with reproduction steps, which reliably trigger it. Interestingly, > the bug does not only manifest as failing assertion, but also as segmentation > fault;

Re: Assertion failure with barriers in parallel hash join

2022-06-02 Thread David Geier
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Hi all, We recently encountered the same bug in the field. Oleks

Re: Assertion failure with barriers in parallel hash join

2021-11-17 Thread Melanie Plageman
On Wed, Mar 31, 2021 at 6:25 PM Melanie Plageman wrote: > > On Wed, Mar 17, 2021 at 8:18 AM Thomas Munro wrote: > > > > On Wed, Mar 17, 2021 at 6:58 PM Thomas Munro wrote: > > > According to BF animal elver there is something wrong with this > > > commit. Looking into it. > > > > Assertion fail

Re: Assertion failure with barriers in parallel hash join

2021-03-31 Thread Melanie Plageman
On Wed, Mar 17, 2021 at 8:18 AM Thomas Munro wrote: > > On Wed, Mar 17, 2021 at 6:58 PM Thomas Munro wrote: > > According to BF animal elver there is something wrong with this > > commit. Looking into it. > > Assertion failure reproduced here and understood, but unfortunately > it'll take some m

Re: Assertion failure with barriers in parallel hash join

2021-03-31 Thread Melanie Plageman
On Wed, Mar 17, 2021 at 8:18 AM Thomas Munro wrote: > > On Wed, Mar 17, 2021 at 6:58 PM Thomas Munro wrote: > > According to BF animal elver there is something wrong with this > > commit. Looking into it. > > Assertion failure reproduced here and understood, but unfortunately > it'll take some m

Re: Assertion failure with barriers in parallel hash join

2021-03-17 Thread Thomas Munro
On Wed, Mar 17, 2021 at 6:58 PM Thomas Munro wrote: > According to BF animal elver there is something wrong with this > commit. Looking into it. Assertion failure reproduced here and understood, but unfortunately it'll take some more time to fix this. I've reverted the commit for now to unbreak

Re: Assertion failure with barriers in parallel hash join

2021-03-16 Thread Thomas Munro
On Wed, Mar 17, 2021 at 6:17 PM Thomas Munro wrote: > On Sat, Mar 6, 2021 at 9:56 AM Thomas Munro wrote: > > While working on Melanie's Parallel Hash Full Join patch I remembered > > that this (apparently extremely rare) race still needs fixing. Here > > is a slightly tidied version, which I'm a

Re: Assertion failure with barriers in parallel hash join

2021-03-16 Thread Thomas Munro
On Sat, Mar 6, 2021 at 9:56 AM Thomas Munro wrote: > While working on Melanie's Parallel Hash Full Join patch I remembered > that this (apparently extremely rare) race still needs fixing. Here > is a slightly tidied version, which I'm adding to the next CF for CI > coverage. Pushed and back-patc

Re: Assertion failure with barriers in parallel hash join

2020-10-12 Thread Thomas Munro
On Tue, Oct 13, 2020 at 12:15 PM Melanie Plageman wrote: > On Thu, Oct 1, 2020 at 8:08 PM Thomas Munro wrote: >> On Tue, Sep 29, 2020 at 9:12 PM Thomas Munro wrote: >> Here's a throw-away patch to add some sleeps that trigger the problem, >> and a first draft fix. I'll do some more testing of t

Re: Assertion failure with barriers in parallel hash join

2020-10-12 Thread Melanie Plageman
On Thu, Oct 1, 2020 at 8:08 PM Thomas Munro wrote: > On Tue, Sep 29, 2020 at 9:12 PM Thomas Munro > wrote: > > On Tue, Sep 29, 2020 at 7:11 PM Michael Paquier > wrote: > > > #2 0x009027d2 in ExceptionalCondition > > > (conditionName=conditionName@entry=0xa80846 "!barrier->static_party"

Re: Assertion failure with barriers in parallel hash join

2020-10-01 Thread Thomas Munro
On Tue, Sep 29, 2020 at 9:12 PM Thomas Munro wrote: > On Tue, Sep 29, 2020 at 7:11 PM Michael Paquier wrote: > > #2 0x009027d2 in ExceptionalCondition > > (conditionName=conditionName@entry=0xa80846 "!barrier->static_party", > > > #4 0x00682ebf in ExecParallelHashJoinNewBatch >

Re: Assertion failure with barriers in parallel hash join

2020-09-29 Thread Thomas Munro
On Tue, Sep 29, 2020 at 7:11 PM Michael Paquier wrote: > #2 0x009027d2 in ExceptionalCondition > (conditionName=conditionName@entry=0xa80846 "!barrier->static_party", > #4 0x00682ebf in ExecParallelHashJoinNewBatch Thanks. Ohhh. I think I see how that condition was reached an

Assertion failure with barriers in parallel hash join

2020-09-28 Thread Michael Paquier
Hi all, prion, that uses -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE, has just failed with an interesting failure: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-09-29%2005%3A24%3A11 The assertion failure happens in a parallel worker when attempting to attach a barrie