Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1

2018-10-05 Thread Michael Paquier
On Fri, Oct 05, 2018 at 11:27:59PM -0300, Alvaro Herrera wrote: > Well, I think partially filling the struct is bad style. I'm going to > be messing with that shortly anyway, when adding support for FKs > pointing to partitioned tables; maybe just leave it as is for now and > I'll see about that l

Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1

2018-10-05 Thread Alvaro Herrera
On 2018-Oct-06, Michael Paquier wrote: > On Fri, Oct 05, 2018 at 12:41:29PM -0300, Alvaro Herrera wrote: > > On 2018-Oct-05, Michael Paquier wrote: > >> Looking at the stack trace there is this log in > >> validateForeignKeyConstraint: > >> ereport(DEBUG1, > >> (errmsg("validating foreign

Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1

2018-10-05 Thread Michael Paquier
On Fri, Oct 05, 2018 at 12:41:29PM -0300, Alvaro Herrera wrote: > On 2018-Oct-05, Michael Paquier wrote: >> Looking at the stack trace there is this log in >> validateForeignKeyConstraint: >> ereport(DEBUG1, >> (errmsg("validating foreign key constraint \"%s\"", conname))); >> >> However c

Re: Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1

2018-10-05 Thread Alvaro Herrera
On 2018-Oct-05, Michael Paquier wrote: > Looking at the stack trace there is this log in > validateForeignKeyConstraint: > ereport(DEBUG1, > (errmsg("validating foreign key constraint \"%s\"", conname))); > > However conname is set to NULL in this code path. Ouch. Thanks for catching th

Assertion failure with ALTER TABLE ATTACH PARTITION with log_min_messages >= DEBUG1

2018-10-04 Thread Michael Paquier
Hi all, Running installcheck on an instance with log_min_messages = DEBUG1, I can bump into the following assertion failure: #2 0x56145231e82c in ExceptionalCondition (conditionName=0x56145258ae0b "!(strvalue != ((void *)0))", errorType=0x56145258adfb "FailedAssertion", fileName=0x5614525