Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Fri, May 23, 2025 at 1:53 PM Melanie Plageman wrote: > > On Fri, May 23, 2025 at 12:41 PM Masahiko Sawada > wrote: > > > > I'll remove that part and push early next week, barring any objections. > > Great, thanks so much! Pushed the fix and closed the open item. Thank you for reviewing the p

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Fri, May 23, 2025 at 12:41 PM Masahiko Sawada wrote: > > I'll remove that part and push early next week, barring any objections. Great, thanks so much! - Melanie

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Thu, May 22, 2025 at 1:19 PM Melanie Plageman wrote: > > On Thu, May 22, 2025 at 4:07 PM Masahiko Sawada wrote: > > > > Agreed. I've updated the patch. Does this address your comments? > > Yep. LGTM. > > I'd probably just remove the parenthetical remark about 20% from the > commit message sinc

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Thu, May 22, 2025 at 4:07 PM Masahiko Sawada wrote: > > Agreed. I've updated the patch. Does this address your comments? Yep. LGTM. I'd probably just remove the parenthetical remark about 20% from the commit message since that only applies to the success cap and referencing both the success a

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Thu, May 22, 2025 at 7:27 AM Melanie Plageman wrote: > > On Wed, May 21, 2025 at 6:11 PM Masahiko Sawada wrote: > > > > > if (vacrel->eager_scan_remaining_successes > 0) > > > vacrel->eager_scan_remaining_successes--; > > > > I've attached a patch that uses this idea. Feedback is very wel

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Wed, May 21, 2025 at 6:11 PM Masahiko Sawada wrote: > > > if (vacrel->eager_scan_remaining_successes > 0) > > vacrel->eager_scan_remaining_successes--; > > I've attached a patch that uses this idea. Feedback is very welcome. Thanks for writing the patch! I actually think we have the same

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Wed, May 21, 2025 at 10:09 AM Melanie Plageman wrote: > > > On Tue, May 20, 2025 at 6:59 PM Masahiko Sawada wrote: >> >> While I haven't identified how exactly read stream is related to this >> issue, what I've observed through debugging this issue is, during a >> single read_stream_next_buffe

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Tue, May 20, 2025 at 6:59 PM Masahiko Sawada wrote: > While I haven't identified how exactly read stream is related to this > issue, what I've observed through debugging this issue is, during a > single read_stream_next_buffer() call, I observed that > heap_vac_scan_next_block() is invoked mul

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Tue, May 20, 2025 at 3:22 PM Melanie Plageman wrote: > > > On Tue, May 20, 2025 at 5:23 PM Masahiko Sawada wrote: >> >> >> On Fri, May 2, 2025 at 11:59 AM Masahiko Sawada >> wrote: >> > >> > However, there is a possibility that we have already eagerly scanned >> > another page and returned i

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

On Tue, May 20, 2025 at 5:23 PM Masahiko Sawada wrote: > > On Fri, May 2, 2025 at 11:59 AM Masahiko Sawada > wrote: > > > > However, there is a possibility that we have already eagerly scanned > > another page and returned it to the read stream before we freeze the > > eagerly-scanned page and d

Re: Assert("vacrel->eager_scan_remaining_successes > 0")

(CC'ed to Melanie) On Fri, May 2, 2025 at 11:59 AM Masahiko Sawada wrote: > > Hi, > > I hit the assertion failure in the subject line with the following script: > > create table t (a int) with (autovacuum_enabled = off); > insert into t select generate_series(1, 1_000_000); > vacuum t; > insert i

Assert("vacrel->eager_scan_remaining_successes > 0")

Hi, I hit the assertion failure in the subject line with the following script: create table t (a int) with (autovacuum_enabled = off); insert into t select generate_series(1, 1_000_000); vacuum t; insert into t select generate_series(1, 1_000_000); set vacuum_freeze_min_age to 0; vacuum t; When