On 19.08.24 08:18, Michael Paquier wrote:
On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
This seems correct to me.
It is not the first time that this happens in recent history. Would
it be worth automating that? I would guess a TAP test that takes a
copy of the headers, applies
On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
> This seems correct to me.
It is not the first time that this happens in recent history. Would
it be worth automating that? I would guess a TAP test that takes a
copy of the headers, applies the changes while filtering the few
excepti
On 8/14/24 12:50, Peter Eisentraut wrote:
On 13.08.24 21:00, Robert Haas wrote:
On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
wrote:
I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
header files. According to the commit message in 8ec569479, all
variables in header fi
On 13.08.24 21:00, Robert Haas wrote:
On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
wrote:
I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
header files. According to the commit message in 8ec569479, all
variables in header files must be marked with PGDLLIMPORT, am I rig
On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
wrote:
> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
> header files. According to the commit message in 8ec569479, all
> variables in header files must be marked with PGDLLIMPORT, am I right?
>
> I've made a patch that adds
look.
--
Best regards,
Sofia Kopikova
Postgres Professional: http://www.postgrespro.com
From 603b0433b9538423a324ae980e0a19d7caaf222e Mon Sep 17 00:00:00 2001
From: Sofia Kopikova
Date: Tue, 13 Aug 2024 16:05:13 +0300
Subject: [PATCH] Apply PGDLLIMPORT markings to some GUC variables
According to the c
