At Mon, 3 Jan 2022 17:36:25 +0900, Michael Paquier wrote
in
> On Fri, Dec 24, 2021 at 09:02:10PM +0900, Michael Paquier wrote:
> > Do we really need to have this comment in the function header? The
> > same is explained a couple of lines down so this feels like a
> > duplicate, and it is hard t
On Fri, Dec 24, 2021 at 09:02:10PM +0900, Michael Paquier wrote:
> Do we really need to have this comment in the function header? The
> same is explained a couple of lines down so this feels like a
> duplicate, and it is hard to miss it with the code shaped as-is (aka
> the relationship between co
On Fri, Dec 24, 2021 at 03:32:10PM +0900, Kyotaro Horiguchi wrote:
> Thanks! Looks better. It is used as-is in the attached.
>
> And I will register this to the next CF.
Do we really need to have this comment in the function header? The
same is explained a couple of lines down so this feels lik
At Mon, 22 Nov 2021 22:50:04 +0800, Julien Rouhaud wrote
in
> On Mon, Nov 22, 2021 at 2:48 PM Kyotaro Horiguchi
> wrote:
> >
> > At Mon, 22 Nov 2021 15:38:23 +0900 (JST), Kyotaro Horiguchi
> > wrote in
> > > * queryId is supposed to be a valid value, otherwise this function
> > > dosen't
>
On Mon, Nov 22, 2021 at 2:48 PM Kyotaro Horiguchi
wrote:
>
> At Mon, 22 Nov 2021 15:38:23 +0900 (JST), Kyotaro Horiguchi
> wrote in
> > * queryId is supposed to be a valid value, otherwise this function dosen't
> > * calucate it by its own as before then returns immediately.
>
> Mmm. That's ba
At Mon, 22 Nov 2021 15:38:23 +0900 (JST), Kyotaro Horiguchi
wrote in
> * queryId is supposed to be a valid value, otherwise this function dosen't
> * calucate it by its own as before then returns immediately.
Mmm. That's bad. This is the correted version.
* queryId is supposed to be a valid
Hello.
I noticed obsolete lines in the function comment of pgss_store().
* If queryId is 0 then this is a utility statement for which we couldn't
* compute a queryId during parse analysis, and we should compute a suitable
* queryId internally.
Previously the function actually calculates query
