Re: Allowing pg_recvlogical to create temporary replication slots

2025-01-26 Thread Michael Paquier
On Tue, Nov 19, 2024 at 09:53:42AM +0900, Michael Paquier wrote: > And concurrency issues like this one are very unlikely going to happen > once you do that. The patch has been waiting for input for 8~9 weeks, so I am marking it as returned with feedback in the CF app. Feel free to resubmit if yo

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-18 Thread Michael Paquier
On Sat, Nov 16, 2024 at 12:49:05PM +0100, Torsten Förtsch wrote: > Thanks. Here is an updated version of the patch including documentation. + +If used together with --if-not-exists and if a +permanent slot by the requested name exists, that slot is used instead +of c

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-16 Thread Torsten Förtsch
On Tue, Nov 12, 2024 at 3:30 PM Dickson S. Guedes wrote: Are you planning to add changes in docs? Would be important to have > this clarification in there also, IMHO. > Thanks. Here is an updated version of the patch including documentation. From 80e2894d3289cebd9c12d457620bf2965cc0252d Mon Sep

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-12 Thread Dickson S. Guedes
Em ter., 12 de nov. de 2024 às 07:54, Torsten Förtsch escreveu: > Hi Dickson, > > [ ... ] > > If the slot existed before, the existing slot will be used, no error is > generated. In that case the slot will keep existing when the connection is > dropped. > > The following situation can happen: >

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-12 Thread Torsten Förtsch
Hi Dickson, > > While reviewing your patch for pg_recvlogical, I’m curious about the > expected behavior when using --if-not-exists in conjunction with > --temporary-slot. > > If an existing slot is reused under these options, will it behave as > a temporary slot and be removed when the connection

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-10 Thread Dickson Guedes
Hello Torsten! While reviewing your patch for pg_recvlogical, I’m curious about the expected behavior when using --if-not-exists in conjunction with --temporary-slot. If an existing slot is reused under these options, will it behave as a temporary slot and be removed when the connection ends?

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-04 Thread Amit Kapila
On Fri, Nov 1, 2024 at 6:13 PM Torsten Förtsch wrote: > > On Wed, Oct 30, 2024 at 9:01 AM Peter Eisentraut wrote: >> >> On 27.10.24 13:37, Torsten Förtsch wrote: >> > The attached patch enables pg_recvlogical to create a temporary slot. >> >> I think you should explain a bit why you want to do th

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-03 Thread Michael Paquier
On Fri, Nov 01, 2024 at 01:42:55PM +0100, Torsten Förtsch wrote: > I was in the process of experimenting with this idea and found that > pg_recvlogical can: > - only create the slot or > - create the slot and immediately use it > - try to create the slot and if the slot is already there use it > >

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-01 Thread Torsten Förtsch
This is another version of the patch. It now includes tests. On Fri, Nov 1, 2024 at 1:42 PM Torsten Förtsch wrote: > On Wed, Oct 30, 2024 at 9:01 AM Peter Eisentraut > wrote: > >> On 27.10.24 13:37, Torsten Förtsch wrote: >> > The attached patch enables pg_recvlogical to create a temporary slo

Re: Allowing pg_recvlogical to create temporary replication slots

2024-11-01 Thread Torsten Förtsch
On Wed, Oct 30, 2024 at 9:01 AM Peter Eisentraut wrote: > On 27.10.24 13:37, Torsten Förtsch wrote: > > The attached patch enables pg_recvlogical to create a temporary slot. > > I think you should explain a bit why you want to do that, what use case > or scenario this is meant to address. > In m

Re: Allowing pg_recvlogical to create temporary replication slots

2024-10-30 Thread Michael Paquier
On Wed, Oct 30, 2024 at 09:00:59AM +0100, Peter Eisentraut wrote: > I think you should explain a bit why you want to do that, what use case or > scenario this is meant to address. Indeed. Note also this page giving a couple more guidelines with more details: https://wiki.postgresql.org/wiki/Submi

Re: Allowing pg_recvlogical to create temporary replication slots

2024-10-30 Thread Peter Eisentraut
On 27.10.24 13:37, Torsten Förtsch wrote: This is my very first message to this mailing list. Please advise if I am making any mistakes in the procedure. Welcome! The attached patch enables pg_recvlogical to create a temporary slot. What is the next step in the process to get this change int

Allowing pg_recvlogical to create temporary replication slots

2024-10-27 Thread Torsten Förtsch
Hi, This is my very first message to this mailing list. Please advise if I am making any mistakes in the procedure. The attached patch enables pg_recvlogical to create a temporary slot. What is the next step in the process to get this change into official postgres? Thanks, Torsten diff --git a/