Re: Allow streaming the changes after speculative aborts.

2021-06-30 Thread Amit Kapila
On Wed, Jun 30, 2021 at 5:38 PM Robert Haas wrote: > > On Wed, Jun 30, 2021 at 4:15 AM Amit Kapila wrote: > > I'm not objecting to the change as such - though someone else may wish > to - but I'm definitely objecting to the timing of the commit. > Okay, I'll wait for more time going forward. Nor

Re: Allow streaming the changes after speculative aborts.

2021-06-30 Thread Robert Haas
On Wed, Jun 30, 2021 at 4:15 AM Amit Kapila wrote: > > > Thanks. Now, that the PG-15 branch is created, I think we should > > > commit this to both 15 and 14 as this is a minor change. What do you > > > think? > > > > Yeah, this is a minor improvement so can be pushed to both 15 and 14. > > Thanks

Re: Allow streaming the changes after speculative aborts.

2021-06-30 Thread Amit Kapila
On Wed, Jun 30, 2021 at 9:55 AM Dilip Kumar wrote: > > On Wed, Jun 30, 2021 at 9:29 AM Amit Kapila wrote: > > > > On Tue, Jun 29, 2021 at 12:57 PM Dilip Kumar wrote: > > > > > > On Fri, Jun 25, 2021 at 12:24 PM Amit Kapila > > > wrote: > > > > > > > > Till now, we didn't allow to stream the ch

Re: Allow streaming the changes after speculative aborts.

2021-06-29 Thread Dilip Kumar
On Wed, Jun 30, 2021 at 9:29 AM Amit Kapila wrote: > > On Tue, Jun 29, 2021 at 12:57 PM Dilip Kumar wrote: > > > > On Fri, Jun 25, 2021 at 12:24 PM Amit Kapila > > wrote: > > > > > > Till now, we didn't allow to stream the changes in logical replication > > > till we receive speculative confirm

Re: Allow streaming the changes after speculative aborts.

2021-06-29 Thread Amit Kapila
On Tue, Jun 29, 2021 at 12:57 PM Dilip Kumar wrote: > > On Fri, Jun 25, 2021 at 12:24 PM Amit Kapila wrote: > > > > Till now, we didn't allow to stream the changes in logical replication > > till we receive speculative confirm or the next DML change record > > after speculative inserts. The reaso

Re: Allow streaming the changes after speculative aborts.

2021-06-29 Thread Dilip Kumar
On Fri, Jun 25, 2021 at 12:24 PM Amit Kapila wrote: > > Till now, we didn't allow to stream the changes in logical replication > till we receive speculative confirm or the next DML change record > after speculative inserts. The reason was that we never use to process > speculative aborts but after

Allow streaming the changes after speculative aborts.

2021-06-24 Thread Amit Kapila
Till now, we didn't allow to stream the changes in logical replication till we receive speculative confirm or the next DML change record after speculative inserts. The reason was that we never use to process speculative aborts but after commit 4daa140a2f it is possible to process them so we can all