Re: Allow simplehash to use already-calculated hash values

2019-07-17 Thread Jeff Davis
On Wed, 2019-07-17 at 11:59 -0700, Andres Freund wrote: > I've not tested it, but this looks reasonable to me. Do you actually > need the lookup variant, or is that more for completeness? Yes. If the hash table is full, I do a lookup. If not, I do an insert. > nitpick^3: I'd s/This is intended fo

Re: Allow simplehash to use already-calculated hash values

2019-07-17 Thread Andres Freund
Hi, On 2019-07-17 11:17:46 -0700, Jeff Davis wrote: > From a6aba8e53f7a36a42922add68098682c2c96683e Mon Sep 17 00:00:00 2001 > From: Jeff Davis > Date: Wed, 17 Jul 2019 10:52:15 -0700 > Subject: [PATCH] Allow simplehash to use already-calculated hash values. > > Ad

Re: Allow simplehash to use already-calculated hash values

2019-07-17 Thread Jeff Davis
Regards, Jeff Davis From a6aba8e53f7a36a42922add68098682c2c96683e Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Wed, 17 Jul 2019 10:52:15 -0700 Subject: [PATCH] Allow simplehash to use already-calculated hash values. Add _lookup_hash and _insert_hash functions for callers that have

Re: Allow simplehash to use already-calculated hash values

2019-07-16 Thread Andres Freund
Hi, On 2019-07-16 15:20:33 -0700, Jeff Davis wrote: > The attached small patch adds new entry points to simplehash.h that > allow the caller to pass in the already-calculated hash value, so that > simplehash doesn't need to recalculate it. > > This is helpful for Memory-Bounded Hash Aggregation[1

Allow simplehash to use already-calculated hash values

2019-07-16 Thread Jeff Davis
value anyway. Regards, Jeff Davis [1] https://postgr.es/m/507ac540ec7c20136364b5272acbcd4574aa76ef.camel%40j-davis.com From ac4877d1e7b64da6caead189b85813fb5fed81a0 Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Tue, 16 Jul 2019 12:07:37 -0700 Subject: [PATCH] Allow simplehash to us