RE: Adding percentile metrics to pg_stat_statements module

2023-06-05 Thread benoit
Envoyé : samedi 2 novembre 2019 10:23:49 À : Tomas Vondra; Igor Calabria Cc : pgsql-hack...@postgresql.org Objet : Re: Adding percentile metrics to pg_stat_statements module On 10/31/19 8:32 PM, Tomas Vondra wrote: > IMO having some sort of CDF approximation (being a q-digest or t-digest) > wo

Re: Adding percentile metrics to pg_stat_statements module

2019-11-02 Thread Adrien Nayrat
On 10/31/19 8:32 PM, Tomas Vondra wrote: > IMO having some sort of CDF approximation (being a q-digest or t-digest) > would be useful, although it'd probably need to be optional (mostly > becuase of memory consumption). +1, I like this idea. If we are afraid of CPU cost we could imagine some kind

Re: Adding percentile metrics to pg_stat_statements module

2019-11-01 Thread Igor Calabria
> > That's not what I wrote. My point was that we *should* store the digests > themselves, otherwise we just introduce additional errors into the > estimates, because it discards the weights/frequencies. Sorry. I meant to write "no reason to *not* store the digests" Em sex, 1 de nov de 2019 às

Re: Adding percentile metrics to pg_stat_statements module

2019-11-01 Thread Tomas Vondra
On Fri, Nov 01, 2019 at 11:11:13AM -0300, Igor Calabria wrote: Yeah, I agree that there's no reason to store the digests themselves and I really liked the idea of it being optional. That's not what I wrote. My point was that we *should* store the digests themselves, otherwise we just introduce

Re: Adding percentile metrics to pg_stat_statements module

2019-11-01 Thread Igor Calabria
Yeah, I agree that there's no reason to store the digests themselves and I really liked the idea of it being optional. If it turns out that memory consumption on real workloads is small enough, it could eventually be turned on by default. I'll start working on patch Em qui, 31 de out de 2019 às 1

Re: Adding percentile metrics to pg_stat_statements module

2019-10-31 Thread Tomas Vondra
On Thu, Oct 31, 2019 at 12:51:17PM -0300, Igor Calabria wrote: Hi everyone, I was taking a look at pg_stat_statements module and noticed that it does not collect any percentile metrics. I believe that It would be really handy to have those available and I'd love to contribute with this feature.

Re: Adding percentile metrics to pg_stat_statements module

2019-10-31 Thread Pavel Stehule
čt 31. 10. 2019 v 16:51 odesílatel Igor Calabria napsal: > Hi everyone, > > I was taking a look at pg_stat_statements module and noticed that it does > not collect any percentile metrics. I believe that It would be really handy > to have those available and I'd love to contribute with this featur

Adding percentile metrics to pg_stat_statements module

2019-10-31 Thread Igor Calabria
Hi everyone, I was taking a look at pg_stat_statements module and noticed that it does not collect any percentile metrics. I believe that It would be really handy to have those available and I'd love to contribute with this feature. The basic idea is to accumulate the the query execution times us