Re: Adding error messages to a few slash commands

2025-04-14 Thread Abhishek Chanda
Thanks Pavel, done now https://commitfest.postgresql.org/patch/5699/ Thanks On Mon, Apr 14, 2025 at 4:27 AM Pavel Luzanov wrote: > > On 13.04.2025 19:40, Abhishek Chanda wrote: > > Thanks for the feedback, attached an updated patch that changes most > of those "Did not find" messages to empty ta

Re: Adding error messages to a few slash commands

2025-04-14 Thread Pavel Luzanov
On 13.04.2025 19:40, Abhishek Chanda wrote: Thanks for the feedback, attached an updated patch that changes most of those "Did not find" messages to empty tables. I did not change two sets, listDbRoleSettings and listTables both have comments describing that these are deliberately this way. Tha

Re: Adding error messages to a few slash commands

2025-04-13 Thread Abhishek Chanda
Thanks for the feedback, attached an updated patch that changes most of those "Did not find" messages to empty tables. I did not change two sets, listDbRoleSettings and listTables both have comments describing that these are deliberately this way. I wanted to post this update to close this loop fo

Re: Adding error messages to a few slash commands

2025-04-12 Thread Pavel Luzanov
On 13.04.2025 08:29, Tom Lane wrote: Abhishek Chanda writes: Currently, some slash commands in psql return an error saying "Did not find any named " while some return an empty table. This patch changes a few of the slash commands to return a similar error message. +1 for this patch.

Re: Adding error messages to a few slash commands

2025-04-12 Thread Tom Lane
Abhishek Chanda writes: > Currently, some slash commands in psql return an error saying "Did not > find any named " while some return an empty table. This patch > changes a few of the slash commands to return a similar error message. Personally, if I were trying to make these things cons

Re: Adding error messages to a few slash commands

2025-04-12 Thread Abhishek Chanda
Sorry, I forgot to attach example usage. Here is how these currently behave: postgres=> \dT foo List of data types Schema | Name | Description +--+- (0 rows) postgres => \du foo List of roles Role name | Attributes ---+ postgres => \df foo

Adding error messages to a few slash commands

2025-04-12 Thread Abhishek Chanda
Hello hackers, Currently, some slash commands in psql return an error saying "Did not find any named " while some return an empty table. This patch changes a few of the slash commands to return a similar error message. I did not change all of the slash commands in this initial patch to wa