Re: Adding argument names to aggregate functions

2023-08-24 Thread Dagfinn Ilmari Mannsåker
On Thu, 24 Aug 2023, at 11:05, Daniel Gustafsson wrote: >> On 4 Aug 2023, at 01:36, Nathan Bossart wrote: >> >> On Wed, Jul 19, 2023 at 09:38:12PM +0200, Daniel Gustafsson wrote: >>> Great, thanks! I had a quick look at this while rebasing (as well as your >>> updated patch) and it seems like a

Re: Adding argument names to aggregate functions

2023-08-24 Thread Daniel Gustafsson
> On 4 Aug 2023, at 01:36, Nathan Bossart wrote: > > On Wed, Jul 19, 2023 at 09:38:12PM +0200, Daniel Gustafsson wrote: >> Great, thanks! I had a quick look at this while rebasing (as well as your >> updated patch) and it seems like a good idea to add this. Unless there are >> objections I will

Re: Adding argument names to aggregate functions

2023-08-03 Thread Nathan Bossart
On Wed, Jul 19, 2023 at 09:38:12PM +0200, Daniel Gustafsson wrote: > Great, thanks! I had a quick look at this while rebasing (as well as your > updated patch) and it seems like a good idea to add this. Unless there are > objections I will look at getting this in. Hey Daniel, are you still plann

Re: Adding argument names to aggregate functions

2023-07-19 Thread Daniel Gustafsson
> On 19 Jul 2023, at 19:32, Dagfinn Ilmari Mannsåker wrote: > > Daniel Gustafsson writes: > >> This patch no longer applied but had a fairly trivial conflict so I've >> attached >> a rebased v3 addressing the conflict in the hopes of getting this further. > > Thanks for the heads-up! Turns o

Re: Adding argument names to aggregate functions

2023-07-19 Thread Dagfinn Ilmari Mannsåker
Daniel Gustafsson writes: > This patch no longer applied but had a fairly trivial conflict so I've > attached > a rebased v3 addressing the conflict in the hopes of getting this further. Thanks for the heads-up! Turns out the conflict was due to the new json(b)_object_agg(_unique)(_strict) fun

Re: Adding argument names to aggregate functions

2023-07-19 Thread Daniel Gustafsson
This patch no longer applied but had a fairly trivial conflict so I've attached a rebased v3 addressing the conflict in the hopes of getting this further. -- Daniel Gustafsson v3-0001-Add-argument-names-to-multi-argument-aggregates.patch Description: Binary data

Re: Adding argument names to aggregate functions

2023-04-18 Thread Jim Jones
On 18.04.23 12:27, Dagfinn Ilmari Mannsåker wrote: Link to the actual job: https://cirrus-ci.com/task/5881376021413888 The failure was: [09:54:38.727] 216/262 postgresql:recovery / recovery/031_recovery_conflict ERROR 198.73s exit status 60 Looking at its log: https://api.cirrus-ci.com/v1/ar

Re: Adding argument names to aggregate functions

2023-04-18 Thread Dagfinn Ilmari Mannsåker
Jim Jones writes: > On 18.04.23 10:58, I wrote: >> On 14.04.23 12:03, Dagfinn Ilmari Mannsåker wrote: >>> Thanks for the heads-up, here's a rebased patch. I've also formatted >>> the lines to match what reformat_dat_file.pl wants.  It also wanted to >>> reformat a bunch of other entries, but I le

Re: Adding argument names to aggregate functions

2023-04-18 Thread Jim Jones
On 18.04.23 10:58, I wrote: On 14.04.23 12:03, Dagfinn Ilmari Mannsåker wrote: Thanks for the heads-up, here's a rebased patch. I've also formatted the lines to match what reformat_dat_file.pl wants.  It also wanted to reformat a bunch of other entries, but I left those alone. - ilmari The pa

Re: Adding argument names to aggregate functions

2023-04-18 Thread Jim Jones
On 14.04.23 12:03, Dagfinn Ilmari Mannsåker wrote: Thanks for the heads-up, here's a rebased patch. I've also formatted the lines to match what reformat_dat_file.pl wants. It also wanted to reformat a bunch of other entries, but I left those alone. - ilmari The patch applies cleanly now and \

Re: Adding argument names to aggregate functions

2023-04-14 Thread Dagfinn Ilmari Mannsåker
Jim Jones writes: > On 12.04.23 19:53, Dagfinn Ilmari Mannsåker wrote: >> Dagfinn Ilmari Mannsåker writes: >> >>> Hi hackers, >>> >>> I'm sure I'm not the only one who can never remember which way around >>> the value and delimiter arguments go for string_agg() and has to look it >>> up in the m

Re: Adding argument names to aggregate functions

2023-04-14 Thread Jim Jones
On 12.04.23 19:53, Dagfinn Ilmari Mannsåker wrote: Dagfinn Ilmari Mannsåker writes: Hi hackers, I'm sure I'm not the only one who can never remember which way around the value and delimiter arguments go for string_agg() and has to look it up in the manual every time. To make it more convenie

Re: Adding argument names to aggregate functions

2023-04-12 Thread Dagfinn Ilmari Mannsåker
Dagfinn Ilmari Mannsåker writes: > Hi hackers, > > I'm sure I'm not the only one who can never remember which way around > the value and delimiter arguments go for string_agg() and has to look it > up in the manual every time. To make it more convenient, here's a patch > that adds proargnames to

Re: Adding argument names to aggregate functions

2023-02-27 Thread Vik Fearing
On 2/27/23 14:22, Dagfinn Ilmari Mannsåker wrote: Hi hackers, I'm sure I'm not the only one who can never remember which way around the value and delimiter arguments go for string_agg() and has to look it up in the manual every time. To make it more convenient, here's a patch that adds proargnam

Adding argument names to aggregate functions

2023-02-27 Thread Dagfinn Ilmari Mannsåker
Hi hackers, I'm sure I'm not the only one who can never remember which way around the value and delimiter arguments go for string_agg() and has to look it up in the manual every time. To make it more convenient, here's a patch that adds proargnames to its pg_proc entries so that it can be seen wit