Re: Added tab completion for the missing options in copy statement

2020-07-20 Thread Michael Paquier
On Sat, Jul 18, 2020 at 04:49:23PM +0530, vignesh C wrote: > Thanks Michael for the clarification, the patch looks fine to me. Thanks for the confirmation, committed. -- Michael signature.asc Description: PGP signature

Re: Added tab completion for the missing options in copy statement

2020-07-18 Thread vignesh C
On Sat, Jul 18, 2020 at 4:36 PM Michael Paquier wrote: > > On Sat, Jul 18, 2020 at 04:12:02PM +0530, vignesh C wrote: > > Can we specify Insert/Update or delete with copy? > > When I tried few scenarios I was getting the following error: > > ERROR: COPY query must have a RETURNING clause > > > >

Re: Added tab completion for the missing options in copy statement

2020-07-18 Thread Michael Paquier
On Sat, Jul 18, 2020 at 04:12:02PM +0530, vignesh C wrote: > Can we specify Insert/Update or delete with copy? > When I tried few scenarios I was getting the following error: > ERROR: COPY query must have a RETURNING clause > > I might be missing some scenarios, just wanted to confirm if this is

Re: Added tab completion for the missing options in copy statement

2020-07-18 Thread vignesh C
On Sat, Jul 18, 2020 at 8:08 AM Michael Paquier wrote: > > On Fri, Jul 17, 2020 at 05:28:51PM +0530, vignesh C wrote: > > On Fri, Jul 17, 2020 at 11:15 AM Michael Paquier > > wrote: > >> Not completely actually. The page of psql for \copy does not mention > >> the optional where clause, and I t

Re: Added tab completion for the missing options in copy statement

2020-07-17 Thread Michael Paquier
On Fri, Jul 17, 2020 at 05:28:51PM +0530, vignesh C wrote: > On Fri, Jul 17, 2020 at 11:15 AM Michael Paquier wrote: >> Not completely actually. The page of psql for \copy does not mention >> the optional where clause, and I think that it would be better to add >> that for consistency (perhaps th

Re: Added tab completion for the missing options in copy statement

2020-07-17 Thread vignesh C
On Fri, Jul 17, 2020 at 11:15 AM Michael Paquier wrote: > > On Fri, Jul 10, 2020 at 09:58:28AM +0530, vignesh C wrote: > > Thanks for reviewing the patch. > > This changes is already present in the document, no need to make any > > changes as shown below: > > > > COPY table_name [ ( column_name [,

Re: Added tab completion for the missing options in copy statement

2020-07-16 Thread Michael Paquier
On Fri, Jul 10, 2020 at 09:58:28AM +0530, vignesh C wrote: > Thanks for reviewing the patch. > This changes is already present in the document, no need to make any > changes as shown below: > > COPY table_name [ ( column_name [, ...] ) ] > FROM { 'filename' | PROGRAM 'command' | STDIN } >

Re: Added tab completion for the missing options in copy statement

2020-07-16 Thread Michael Paquier
On Tue, Jul 07, 2020 at 01:06:38PM +, ahsan hadi wrote: > Tested the tab complete for copy command, it provides the tab > completion after providing the "TO|FROM filename With|Where". Does > this require any doc change? No documentation changes are required for that, as long as they match the

Re: Added tab completion for the missing options in copy statement

2020-07-09 Thread vignesh C
On Sat, Jun 27, 2020 at 6:52 AM vignesh C wrote: > > Hi, > > I found that tab completion for some parts of the copy statement was > missing. The Tab completion was missing for the following cases: > 1) COPY [BINARY] FROM filename -> "BINARY", "DELIMITER", "NULL", > "CSV", "ENCODING", "WITH (", "W

Re: Added tab completion for the missing options in copy statement

2020-07-07 Thread ahsan hadi
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested Tested the tab complete for copy command, it provides the tab com

Added tab completion for the missing options in copy statement

2020-06-26 Thread vignesh C
Hi, I found that tab completion for some parts of the copy statement was missing. The Tab completion was missing for the following cases: 1) COPY [BINARY] FROM filename -> "BINARY", "DELIMITER", "NULL", "CSV", "ENCODING", "WITH (", "WHERE" should be shown. 2) COPY [BINARY] TO filename -> "BINARY