On 5/10/23 12:41 PM, Amit Kapila wrote:
On Tue, May 9, 2023 at 12:44 PM Drouvot, Bertrand
Pushed this yesterday.
Thanks!
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
On Tue, May 9, 2023 at 12:44 PM Drouvot, Bertrand
wrote:
>
> On 5/9/23 8:02 AM, Amit Kapila wrote:
> > On Mon, May 8, 2023 at 1:45 PM Drouvot, Bertrand
> > wrote:
>
> >
> > Why not initialize the cascading standby node just before the standby
> > promotion test: "Test standby promotion and logica
Hi,
On 5/9/23 8:02 AM, Amit Kapila wrote:
On Mon, May 8, 2023 at 1:45 PM Drouvot, Bertrand
wrote:
Why not initialize the cascading standby node just before the standby
promotion test: "Test standby promotion and logical decoding behavior
after the standby gets promoted."? That way we will a
On Mon, May 8, 2023 at 1:45 PM Drouvot, Bertrand
wrote:
>
> On 5/8/23 4:42 AM, Amit Kapila wrote:
> > On Sat, May 6, 2023 at 9:33 PM Drouvot, Bertrand
> > wrote:
> >>
> >> On 5/6/23 3:28 PM, Amit Kapila wrote:
> >>> On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand
> >>> wrote:
> >>
> >>> Next st
Hi,
On 5/8/23 4:42 AM, Amit Kapila wrote:
On Sat, May 6, 2023 at 9:33 PM Drouvot, Bertrand
wrote:
On 5/6/23 3:28 PM, Amit Kapila wrote:
On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand
wrote:
Next steps:
=
1. The first thing is we should verify this theory by adding some LOG
in K
On Sat, May 6, 2023 at 9:33 PM Drouvot, Bertrand
wrote:
>
> On 5/6/23 3:28 PM, Amit Kapila wrote:
> > On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand
> > wrote:
>
> > Next steps:
> > =
> > 1. The first thing is we should verify this theory by adding some LOG
> > in KeepLogSeg() to see if
Hi,
On 5/6/23 3:28 PM, Amit Kapila wrote:
On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand
wrote:
There is 2 runs with this extra info in place:
A successful one: https://cirrus-ci.com/task/6528745436086272
A failed one: https://cirrus-ci.com/task/4558139312308224
Thanks, I think I got so
On Sat, May 6, 2023 at 1:52 PM Drouvot, Bertrand
wrote:
>
> There is 2 runs with this extra info in place:
>
> A successful one: https://cirrus-ci.com/task/6528745436086272
> A failed one: https://cirrus-ci.com/task/4558139312308224
>
Thanks, I think I got some clue as to why this test is failing
Hi,
On 5/6/23 4:10 AM, Amit Kapila wrote:
On Fri, May 5, 2023 at 7:53 PM Drouvot, Bertrand
wrote:
On 5/5/23 2:28 PM, Amit Kapila wrote:
On Fri, May 5, 2023 at 5:36 PM Drouvot, Bertrand
So, even on a successful test, we can see that the WAL file we expect to be
removed on the standby has n
On Fri, May 5, 2023 at 7:53 PM Drouvot, Bertrand
wrote:
>
>
> On 5/5/23 2:28 PM, Amit Kapila wrote:
> > On Fri, May 5, 2023 at 5:36 PM Drouvot, Bertrand
> > wrote:
> >
> > It seems due to some reason the current wal file is not switched due
> > to some reason.
>
> Oh wait, here is a NON failing o
On 5/5/23 2:28 PM, Amit Kapila wrote:
On Fri, May 5, 2023 at 5:36 PM Drouvot, Bertrand
wrote:
It seems due to some reason the current wal file is not switched due
to some reason.
Oh wait, here is a NON failing one: https://cirrus-ci.com/task/5086849685782528
(I modified the
.cirrus.yml so
On Fri, May 5, 2023 at 5:36 PM Drouvot, Bertrand
wrote:
>
> On 5/5/23 12:58 PM, Amit Kapila wrote:
> > On Fri, May 5, 2023 at 4:02 PM Drouvot, Bertrand
> > wrote:
>
> > How did you concluded that 00010003 is the file the
> > test is expecting to be removed?
> >
> because I added a
On 5/5/23 12:58 PM, Amit Kapila wrote:
On Fri, May 5, 2023 at 4:02 PM Drouvot, Bertrand
wrote:
How did you concluded that 00010003 is the file the
test is expecting to be removed?
because I added a note in the test that way:
"
@@ -535,6 +539,7 @@ $node_standby->safe_psql
On Fri, May 5, 2023 at 4:02 PM Drouvot, Bertrand
wrote:
>
> On 5/5/23 11:29 AM, Amit Kapila wrote:
> > On Fri, May 5, 2023 at 1:16 PM Drouvot, Bertrand
> > wrote:
> >>
> >>
> >> After multiple attempts, I got one failing one.
> >>
> >> Issue is that we expect this file to be removed:
> >>
> >> [0
On 5/5/23 11:29 AM, Amit Kapila wrote:
On Fri, May 5, 2023 at 1:16 PM Drouvot, Bertrand
wrote:
After multiple attempts, I got one failing one.
Issue is that we expect this file to be removed:
[07:24:27.261](0.899s) #WAL file is
/Users/admin/pgsql/build/testrun/recovery/035_standby_logic
On Fri, May 5, 2023 at 2:59 PM Amit Kapila wrote:
>
> On Fri, May 5, 2023 at 1:16 PM Drouvot, Bertrand
> wrote:
> >
> >
> > After multiple attempts, I got one failing one.
> >
> > Issue is that we expect this file to be removed:
> >
> > [07:24:27.261](0.899s) #WAL file is
> > /Users/admin/pgsql/
On Fri, May 5, 2023 at 1:16 PM Drouvot, Bertrand
wrote:
>
>
> After multiple attempts, I got one failing one.
>
> Issue is that we expect this file to be removed:
>
> [07:24:27.261](0.899s) #WAL file is
> /Users/admin/pgsql/build/testrun/recovery/035_standby_logical_decoding/data/t_035_standby_lo
On 5/5/23 9:04 AM, Amit Kapila wrote:
On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
wrote:
On 5/4/23 6:43 AM, Amit Kapila wrote:
On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
Thanks for posting the updated patch, I had run this test in a loop of
100 times to verify that there was
Hi,
On 5/5/23 9:11 AM, vignesh C wrote:
On Fri, 5 May 2023 at 12:34, Amit Kapila wrote:
On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
wrote:
On 5/4/23 6:43 AM, Amit Kapila wrote:
On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
Thanks for posting the updated patch, I had run this te
On Fri, 5 May 2023 at 12:34, Amit Kapila wrote:
>
> On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
> wrote:
> >
> > On 5/4/23 6:43 AM, Amit Kapila wrote:
> > > On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
> > >>
> > >> Thanks for posting the updated patch, I had run this test in a loop of
On Fri, May 5, 2023 at 11:08 AM Drouvot, Bertrand
wrote:
>
> On 5/4/23 6:43 AM, Amit Kapila wrote:
> > On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
> >>
> >> Thanks for posting the updated patch, I had run this test in a loop of
> >> 100 times to verify that there was no failure because of rac
Hi,
On 5/4/23 6:43 AM, Amit Kapila wrote:
On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
Thanks for posting the updated patch, I had run this test in a loop of
100 times to verify that there was no failure because of race
conditions. The 100 times execution passed successfully.
One suggesti
Hi,
On 5/4/23 6:43 AM, Amit Kapila wrote:
On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
Thanks for posting the updated patch, I had run this test in a loop of
100 times to verify that there was no failure because of race
conditions. The 100 times execution passed successfully.
One suggesti
On Thu, May 4, 2023 at 8:37 AM vignesh C wrote:
>
> Thanks for posting the updated patch, I had run this test in a loop of
> 100 times to verify that there was no failure because of race
> conditions. The 100 times execution passed successfully.
>
> One suggestion:
> "wal file" should be changed t
On Wed, 3 May 2023 at 15:59, Amit Kapila wrote:
>
> On Tue, May 2, 2023 at 4:52 PM Drouvot, Bertrand
> wrote:
> >
> >
> > As per your suggestion, changing the insert ordering (like in V8 attached)
> > makes it now work on the failing environment too.
> >
>
> I think it is better to use wait_for_
Hi,
On 5/3/23 12:29 PM, Amit Kapila wrote:
On Tue, May 2, 2023 at 4:52 PM Drouvot, Bertrand
wrote:
As per your suggestion, changing the insert ordering (like in V8 attached)
makes it now work on the failing environment too.
I think it is better to use wait_for_replay_catchup() to wait fo
On Tue, May 2, 2023 at 4:52 PM Drouvot, Bertrand
wrote:
>
>
> As per your suggestion, changing the insert ordering (like in V8 attached)
> makes it now work on the failing environment too.
>
I think it is better to use wait_for_replay_catchup() to wait for
standby to catch up. I have changed tha
Hi,
On 5/2/23 8:28 AM, Amit Kapila wrote:
On Fri, Apr 28, 2023 at 2:24 PM Drouvot, Bertrand
wrote:
I can see V7 failing on "Cirrus CI / macOS - Ventura - Meson" only (other
machines are not complaining).
It does fail on "invalidated logical slots do not lead to retaining WAL", see
https://
On Fri, Apr 28, 2023 at 2:24 PM Drouvot, Bertrand
wrote:
>
> > Can you
> > please explain the logic behind this test a bit more like how the WAL
> > file switch helps you to achieve the purpose?
> >
>
> The idea was to generate enough "wal switch" on the primary to ensure
> the WAL file has been r
Hi,
On 4/28/23 5:55 AM, Amit Kapila wrote:
On Wed, Apr 26, 2023 at 7:53 PM Drouvot, Bertrand
wrote:
+# Get the restart_lsn from an invalidated slot
+my $restart_lsn = $node_standby->safe_psql('postgres',
+ "SELECT restart_lsn from pg_replication_slots WHERE slot_name =
'vacuum_full_activeslot'
On Wed, Apr 26, 2023 at 7:53 PM Drouvot, Bertrand
wrote:
>
> > Besides, would it be better to wait for the cascading standby? If the wal
> > log
> > file needed for cascading standby is removed on the standby, the subsequent
> > test
> > will fail.
>
> Good catch! I agree that we have to wait on
On 4/27/23 11:54 AM, Amit Kapila wrote:
On Thu, Apr 27, 2023 at 1:05 PM Drouvot, Bertrand
wrote:
On 4/27/23 5:37 AM, Amit Kapila wrote:
On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
wrote:
+When in recovery, the default value of target_lsn is $node->lsn('replay')
+instead. This is ne
On Thu, Apr 27, 2023 at 1:05 PM Drouvot, Bertrand
wrote:
>
> On 4/27/23 5:37 AM, Amit Kapila wrote:
> > On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
> > wrote:
> >
> > +When in recovery, the default value of target_lsn is $node->lsn('replay')
> > +instead. This is needed when the publisher p
Hi,
On 4/27/23 5:37 AM, Amit Kapila wrote:
On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
wrote:
+When in recovery, the default value of target_lsn is $node->lsn('replay')
+instead. This is needed when the publisher passed to
wait_for_subscription_sync()
+is a standby node.
I think this wi
On Wed, Apr 26, 2023 at 4:41 PM Drouvot, Bertrand
wrote:
>
> On 4/26/23 12:27 PM, Alvaro Herrera wrote:
> >> diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm
> >> b/src/test/perl/PostgreSQL/Test/Cluster.pm
> >> index 6f7f4e5de4..819667d42a 100644
> >> --- a/src/test/perl/PostgreSQL/Test/Clus
Hi,
On 4/26/23 11:58 AM, Yu Shi (Fujitsu) wrote:
On Mon, Apr 24, 2023 8:07 PM Drouvot, Bertrand
wrote:
I think that's because when replaying a checkpoint record, the startup process
of standby only saves the information of the checkpoint, and we need to wait for
the checkpointer to perform
Hi,
On 4/26/23 11:12 AM, vignesh C wrote:
On Wed, 26 Apr 2023 at 13:45, Drouvot, Bertrand
There was one typo in the commit message, subscribtion should be
subscription, the rest of the changes looks good to me:
Subject: [PATCH v5] Add subscribtion to the standby test in
035_standby_logical_de
Hi,
On 4/26/23 12:27 PM, Alvaro Herrera wrote:
diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm
b/src/test/perl/PostgreSQL/Test/Cluster.pm
index 6f7f4e5de4..819667d42a 100644
--- a/src/test/perl/PostgreSQL/Test/Cluster.pm
+++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
@@ -2644,7 +2644,16 @
> diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm
> b/src/test/perl/PostgreSQL/Test/Cluster.pm
> index 6f7f4e5de4..819667d42a 100644
> --- a/src/test/perl/PostgreSQL/Test/Cluster.pm
> +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
> @@ -2644,7 +2644,16 @@ sub wait_for_catchup
> }
>
On Mon, Apr 24, 2023 8:07 PM Drouvot, Bertrand
wrote:
>
> On 4/24/23 11:45 AM, Amit Kapila wrote:
> > On Mon, Apr 24, 2023 at 11:54 AM Amit Kapila
> wrote:
> >>
> >> On Mon, Apr 24, 2023 at 11:24 AM Drouvot, Bertrand
> >> wrote:
> >>>
> >>
> >> Few comments:
> >>
> >>
> >
> > +# W
On Wed, 26 Apr 2023 at 13:45, Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 4/26/23 6:06 AM, vignesh C wrote:
> > On Tue, 25 Apr 2023 at 12:51, Drouvot, Bertrand
> > wrote:
> > Thanks for the updated patch.
> > Few comments:
>
> Thanks for looking at it!
>
> > 1) subscriber_stdout and subscriber_stder
Hi,
On 4/26/23 6:06 AM, vignesh C wrote:
On Tue, 25 Apr 2023 at 12:51, Drouvot, Bertrand
wrote:
Thanks for the updated patch.
Few comments:
Thanks for looking at it!
1) subscriber_stdout and subscriber_stderr are not required for this
test case, we could remove it, I was able to remove tho
On Tue, 25 Apr 2023 at 12:51, Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 4/25/23 6:23 AM, Amit Kapila wrote:
> > On Mon, Apr 24, 2023 at 3:36 PM Drouvot, Bertrand
> > wrote:
> >>
> >> Without the second "pg_log_standby_snapshot()" then
> >> wait_for_subscription_sync() would be waiting
> >> some ti
Hi,
On 4/25/23 6:43 AM, Amit Kapila wrote:
On Mon, Apr 24, 2023 at 5:38 PM Drouvot, Bertrand
wrote:
We are waiting here at a maximum for 10 * $default_timeout (means 3 minutes)
before
we time out. Would you prefer to wait more than 3 minutes at a maximum?
No, because I don't know what wou
Hi,
On 4/25/23 6:23 AM, Amit Kapila wrote:
On Mon, Apr 24, 2023 at 3:36 PM Drouvot, Bertrand
wrote:
Without the second "pg_log_standby_snapshot()" then
wait_for_subscription_sync() would be waiting
some time on the poll for "SELECT count(1) = 0 FROM pg_subscription_rel WHERE
srsubstate NOT
On Mon, Apr 24, 2023 at 5:38 PM Drouvot, Bertrand
wrote:
>
> On 4/24/23 11:45 AM, Amit Kapila wrote:
> > On Mon, Apr 24, 2023 at 11:54 AM Amit Kapila
> > wrote:
> >>
> >> On Mon, Apr 24, 2023 at 11:24 AM Drouvot, Bertrand
> >> wrote:
> >>>
> >>
> >> Few comments:
> >>
> >>
> >
> >
On Mon, Apr 24, 2023 at 3:36 PM Drouvot, Bertrand
wrote:
>
> On 4/24/23 8:24 AM, Amit Kapila wrote:
>
> > 2.
> > +# Speed up the subscription creation
> > +$node_primary->safe_psql('postgres', "SELECT pg_log_standby_snapshot()");
> > +
> > +# Explicitly shut down psql instance gracefully - to avoi
Hi,
On 4/24/23 11:45 AM, Amit Kapila wrote:
On Mon, Apr 24, 2023 at 11:54 AM Amit Kapila wrote:
On Mon, Apr 24, 2023 at 11:24 AM Drouvot, Bertrand
wrote:
Few comments:
+# We can not test if the WAL file still exists immediately.
+# We need to let some time to the standby
Hi,
On 4/24/23 8:24 AM, Amit Kapila wrote:
On Mon, Apr 24, 2023 at 11:24 AM Drouvot, Bertrand
wrote:
Few comments:
Thanks for looking at it!
1.
+$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->append_conf('postgresql.conf', 'max_replication_slots =
On Mon, Apr 24, 2023 at 11:54 AM Amit Kapila wrote:
>
> On Mon, Apr 24, 2023 at 11:24 AM Drouvot, Bertrand
> wrote:
> >
>
> Few comments:
>
>
+# We can not test if the WAL file still exists immediately.
+# We need to let some time to the standby to actually "remove" it.
+my $i = 0;
On Wed, Apr 12, 2023 at 9:45 PM Drouvot, Bertrand
wrote:
>
>
> The attached patch also removes:
>
> "
> -log_min_messages = 'debug2'
> -log_error_verbosity = verbose
> "
>
> as also discussed in [1].
>
I agree that we should reduce the log level here. It is discussed in
an email [1]. I'll push th
On Mon, Apr 24, 2023 at 11:24 AM Drouvot, Bertrand
wrote:
>
Few comments:
1.
+$node_subscriber->init(allows_streaming => 'logical');
+$node_subscriber->append_conf('postgresql.conf', 'max_replication_slots = 4');
Why do we need slots on the subscriber?
2.
+# Speed up the subscripti
Hi,
On 4/24/23 6:04 AM, vignesh C wrote:
On Wed, 12 Apr 2023 at 21:45, Drouvot, Bertrand
wrote:
hi hackers,
In the logical decoding on standby thread [1], Andres proposed 2 new tests
(that I did
not find the time to complete before the finish line):
- Test that we can subscribe to the stan
On Wed, 12 Apr 2023 at 21:45, Drouvot, Bertrand
wrote:
>
> hi hackers,
>
> In the logical decoding on standby thread [1], Andres proposed 2 new tests
> (that I did
> not find the time to complete before the finish line):
>
> - Test that we can subscribe to the standby (with the publication create
Hi,
On 4/17/23 11:55 AM, Alvaro Herrera wrote:
On 2023-Apr-12, Drouvot, Bertrand wrote:
I'm not sure if adding those 2 tests should be considered as an open
item. I can add this open item if we think that makes sense. I'd be
happy to do so but it looks like I don't have the privileges to edit
On 2023-Apr-12, Drouvot, Bertrand wrote:
> I'm not sure if adding those 2 tests should be considered as an open
> item. I can add this open item if we think that makes sense. I'd be
> happy to do so but it looks like I don't have the privileges to edit
> https://wiki.postgresql.org/wiki/PostgreSQL
hi hackers,
In the logical decoding on standby thread [1], Andres proposed 2 new tests
(that I did
not find the time to complete before the finish line):
- Test that we can subscribe to the standby (with the publication created on
the primary)
- Verify that invalidated logical slots do not lea
57 matches
Mail list logo
