On 26.12.24 00:52, Jelte Fennema-Nio wrote:
On Mon, 7 Oct 2024 at 22:21, Jelte Fennema-Nio wrote:
Is this blocked on anything? I feel it's ready to merge at this point.
I'd really like to not have this problem with trailing whitespace in
sgml files anymore.
I noticed Peter added some addition
On Mon, 7 Oct 2024 at 22:21, Jelte Fennema-Nio wrote:
> Is this blocked on anything? I feel it's ready to merge at this point.
> I'd really like to not have this problem with trailing whitespace in
> sgml files anymore.
I noticed Peter added some additional rules to .gitattributes last
month. So
On Thu, 5 Sept 2024 at 23:28, Jelte Fennema-Nio wrote:
> Okay, I've done this now.
Is this blocked on anything? I feel it's ready to merge at this point.
I'd really like to not have this problem with trailing whitespace in
sgml files anymore.
On Fri, 9 Aug 2024 at 16:09, Jelte Fennema-Nio wrote:
> That's there so that the generated .editorconfig file the correct
> indent_size. I guess another approach would be to change the
> generate_editorconfig.py script to include hardcoded values for these
> 4 filetypes.
Okay, I've done this now.
On Fri, 9 Aug 2024 at 15:16, Peter Eisentraut wrote:
> -*.sgml whitespace=space-before-tab,trailing-space,tab-in-indent
> -*.x[ms]l whitespace=space-before-tab,trailing-space,tab-in-indent
> +*.py
> whitespace=space-before-tab,trailing-space,tab-in-indent,tabwidth=4
> +*.s
On 07.08.24 22:42, Jelte Fennema-Nio wrote:
I also added a .gitattributes rule for .py files, and changed the
default tab_width to unset. Because I realized the resulting
.editorconfig was using tab_width 8 for python files when editing
src/tools/generate_editorconfig.py
This looks kind of weir
On 2024-08-07 We 4:42 PM, Jelte Fennema-Nio wrote:
On Wed, 7 Aug 2024 at 21:09, Andrew Dunstan wrote:
You're not meant to use our pg_bsd_indent on its own without the
appropriate flags, namely (from src/tools/pgindent/pgindent):
Ah sorry, I wasn't clear in what I meant then. I meant that if y
On Wed, 7 Aug 2024 at 21:09, Andrew Dunstan wrote:
> You're not meant to use our pg_bsd_indent on its own without the
> appropriate flags, namely (from src/tools/pgindent/pgindent):
Ah sorry, I wasn't clear in what I meant then. I meant that if you
look at the sources of pg_bsd_indent (such as
sr
On 2024-08-07 We 1:09 PM, Jelte Fennema-Nio wrote:
On Tue, 9 Apr 2024 at 12:42, Jelte Fennema-Nio wrote:
Okay, I spent the time to add a script to generate the editorconfig
based on .gitattributes after all. So attached is a patch that adds
that.
I would love to see this patch merged (or at
On Tue, 9 Apr 2024 at 12:42, Jelte Fennema-Nio wrote:
> Okay, I spent the time to add a script to generate the editorconfig
> based on .gitattributes after all. So attached is a patch that adds
> that.
I would love to see this patch merged (or at least some feedback on
the latest version). I thin
On Thu, 4 Apr 2024 at 16:58, Jelte Fennema-Nio wrote:
> > ISTM that with a small shell script, .editorconfig could be generated
> > from .gitattributes?
>
> Honestly, I don't think building such automation is worth the effort.
Okay, I spent the time to add a script to generate the editorconfig
ba
On Thu, 4 Apr 2024 at 17:23, Peter Eisentraut wrote:
> git diff-tree --check $(git hash-object -t tree /dev/null) HEAD
>
> That's what I was hoping for for editorconfig-check, but as I said, the
> experience wasn't good.
Ah, I wasn't able to find that git incantation. I definitely think it
w
On 04.04.24 16:58, Jelte Fennema-Nio wrote:
On Thu, 4 Apr 2024 at 15:25, Peter Eisentraut wrote:
Everybody has git. Everybody who edits .gitattributes can use git to
check what they did.
What CLI command do you use to fix/ gitattributes on all existing
files? Afaict there's no command to actu
On Thu, 4 Apr 2024 at 15:25, Peter Eisentraut wrote:
> Everybody has git. Everybody who edits .gitattributes can use git to
> check what they did.
What CLI command do you use to fix/ gitattributes on all existing
files? Afaict there's no command to actually remove the trailing
whitespace that gi
On 19.02.24 16:21, Jelte Fennema-Nio wrote:
v3-0003-Bring-editorconfig-in-line-with-gitattributes.patch
I question whether we need to add rules to .editorconfig about files
that are generated or imported from elsewhere, since those are not meant
to be edited.
I agree that it's not strictly nece
On Fri, 16 Feb 2024 at 11:45, Peter Eisentraut wrote:
> I have committed that one.
Thanks :)
> v3-0002-Require-final-newline-in-.po-files.patch
>
> The .po files are imported from elsewhere, so I'm not sure this is going
> to have the desired effect. Perhaps it's worth cleaning up, but it
> wou
v3-0001-Remove-non-existing-file-from-.gitattributes.patch
I have committed that one.
v3-0002-Require-final-newline-in-.po-files.patch
The .po files are imported from elsewhere, so I'm not sure this is going
to have the desired effect. Perhaps it's worth cleaning up, but it
would require mor
On Thu, 15 Feb 2024 at 16:57, Peter Eisentraut wrote:
> Is there a command-line tool to verify the syntax of .editorconfig and
> check compliance of existing files?
>
> I'm worried that expanding .editorconfig with detailed per-file rules
> will lead to a lot of mistakes and blind editing, if we d
On 15.02.24 10:26, Jelte Fennema-Nio wrote:
On Wed, 14 Feb 2024 at 23:19, Daniel Gustafsson wrote:
+1 from me. But when do we want it to be false? That is, why not
declare it true for all file types?
Regression test .out files commonly have spaces at the end of the line. (Not
to mention the
On Wed, 14 Feb 2024 at 23:19, Daniel Gustafsson wrote:
> > +1 from me. But when do we want it to be false? That is, why not
> > declare it true for all file types?
>
> Regression test .out files commonly have spaces at the end of the line. (Not
> to mention the ECPG .c files but they probably rea
> On 14 Feb 2024, at 23:06, Melanie Plageman wrote:
>
> On Wed, Feb 14, 2024 at 11:35 AM Jelte Fennema-Nio wrote:
>>
>> This brings our .gitattributes and .editorconfig files more in line. I
>> had the problem that "git add" would complain often about trailing
>> whitespaces when I was changing
On Wed, Feb 14, 2024 at 11:35 AM Jelte Fennema-Nio wrote:
>
> This brings our .gitattributes and .editorconfig files more in line. I
> had the problem that "git add" would complain often about trailing
> whitespaces when I was changing sgml files specifically.
+1 from me. But when do we want it t
This brings our .gitattributes and .editorconfig files more in line. I
had the problem that "git add" would complain often about trailing
whitespaces when I was changing sgml files specifically.
v1-0001-Configure-trailing-whitespace-trimming-in-editorc.patch
Description: Binary data
23 matches
Mail list logo
