On 23.10.23 22:34, Nathan Bossart wrote:
On Mon, Oct 23, 2023 at 05:55:32PM +0800, Junwang Zhao wrote:
On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut wrote:
Since C99, there can be a trailing comma after the last value in an enum
C99 allows us to do this doesn't mean we must do this, this
On 2023-10-23 Mo 17:04, Tom Lane wrote:
Nathan Bossart writes:
From a long-term perspective, I
think standardizing on the trailing comma style will actually improve
git-blame because patches won't need to add a comma to the previous line
when adding a value.
Yeah, that's a good point. I ha
On Tue, Oct 24, 2023 at 4:34 AM Nathan Bossart wrote:
>
> On Mon, Oct 23, 2023 at 05:55:32PM +0800, Junwang Zhao wrote:
> > On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut
> > wrote:
> >> Since C99, there can be a trailing comma after the last value in an enum
> >
> > C99 allows us to do this d
On 10/23/23 17:04, Tom Lane wrote:
Nathan Bossart writes:
From a long-term perspective, I
think standardizing on the trailing comma style will actually improve
git-blame because patches won't need to add a comma to the previous line
when adding a value.
Yeah, that's a good point. I had been
Nathan Bossart writes:
> From a long-term perspective, I
> think standardizing on the trailing comma style will actually improve
> git-blame because patches won't need to add a comma to the previous line
> when adding a value.
Yeah, that's a good point. I had been leaning towards "this is
unnece
On Mon, Oct 23, 2023 at 05:55:32PM +0800, Junwang Zhao wrote:
> On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut wrote:
>> Since C99, there can be a trailing comma after the last value in an enum
>
> C99 allows us to do this doesn't mean we must do this, this is not
> inconsistent IMHO, and this
On Mon, Oct 23, 2023 at 2:37 PM Peter Eisentraut wrote:
>
> Since C99, there can be a trailing comma after the last value in an enum
C99 allows us to do this doesn't mean we must do this, this is not
inconsistent IMHO, and this will pollute the git log messages, people
may *git blame* the file an
