Dong Wook Lee writes:
>>> Couldn't you use $node->wait_for_log() instead?
> After trimming the code a little more, I sent the patch again.
This is much better, but still has some issues:
* The prefetch test might as well not be there, because
check_pg_config("#USE_PREFETCH 1") will never succee
2022년 8월 1일 (월) 오후 11:33, Dong Wook Lee 님이 작성:
>
> Thank you for letting me know.
> I edited my patch with `wait_for_log()`.
>
> 2022년 8월 1일 (월) 오후 6:55, Julien Rouhaud 님이 작성:
> >
> > On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote:
> > >
> > > > Keep in mind also that the logfile accumulates o
Thank you for letting me know.
I edited my patch with `wait_for_log()`.
2022년 8월 1일 (월) 오후 6:55, Julien Rouhaud 님이 작성:
>
> On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote:
> >
> > > Keep in mind also that the logfile accumulates over stops and
> > > restarts. As you've coded this test, you do
Julien Rouhaud writes:
> On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote:
>> I have no idea how to deal with race conditions.
>> Does anybody know how to deal with this?
> Couldn't you use $node->wait_for_log() instead?
Yeah. The standard usage pattern for that also covers the issue
of not
On Mon, Aug 1, 2022 at 5:16 PM Dong Wook Lee wrote:
>
> > Keep in mind also that the logfile accumulates over stops and
> > restarts. As you've coded this test, you don't know which DB start
> > emitted the matching line, so the test proves a lot less than it
> > ought to.
> >
> > I wonder also a
Justin Pryzby writes:
> On Wed, Jun 29, 2022 at 02:38:12PM +0900, Dong Wook Lee wrote:
>> I wrote a test for pg_prewarm extension. and I wrote it with the aim of
>> improving test coverage, and feedback is always welcome.
> The test fails when USE_PREFETCH isn't defined.
> You can accommodate th
On Wed, Jun 29, 2022 at 02:38:12PM +0900, Dong Wook Lee wrote:
> Hi hackers,
> I wrote a test for pg_prewarm extension. and I wrote it with the aim of
> improving test coverage, and feedback is always welcome.
The test fails when USE_PREFETCH isn't defined.
http://cfbot.cputube.org/dongwook-lee.h
Hi hackers,
I wrote a test for pg_prewarm extension. and I wrote it with the aim of
improving test coverage, and feedback is always welcome.
---
Regards
DongWook Lee
diff --git a/contrib/pg_prewarm/Makefile b/contrib/pg_prewarm/Makefile
index b13ac3c813..617ac8e09b 100644
--- a/contrib/pg_prewar
