Re: Add test module for Table Access Method

2024-01-16 Thread Mats Kindahl
On Tue, Jan 16, 2024 at 6:15 AM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > On Tue, Jan 16, 2024 at 10:28 AM Michael Paquier > wrote: > > > > Hmm. I'd rather have it do something useful in terms of test coverage > > rather than being just an empty skull. > > > > How abou

Re: Add test module for Table Access Method

2024-01-16 Thread Mats Kindahl
Hi all, On Tue, Jan 16, 2024 at 10:40 AM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi, > > > > I think a test module for a table AM will really help developers. Just > > > to add to the above list - how about the table AM implementing a > > > simple in-memory (columnar if possible)

Re: Add test module for Table Access Method

2024-01-16 Thread Aleksander Alekseev
Hi, > > I think a test module for a table AM will really help developers. Just > > to add to the above list - how about the table AM implementing a > > simple in-memory (columnar if possible) database storing tables > > in-memory and subsequently providing readers with the access to the > > tables

Re: Add test module for Table Access Method

2024-01-15 Thread Japin Li
On Tue, 16 Jan 2024 at 13:15, Bharath Rupireddy wrote: > On Tue, Jan 16, 2024 at 10:28 AM Michael Paquier wrote: >> >> Hmm. I'd rather have it do something useful in terms of test coverage >> rather than being just an empty skull. >> >> How about adding the same kind of coverage as dummy_inde

Re: Add test module for Table Access Method

2024-01-15 Thread Bharath Rupireddy
On Tue, Jan 16, 2024 at 10:28 AM Michael Paquier wrote: > > Hmm. I'd rather have it do something useful in terms of test coverage > rather than being just an empty skull. > > How about adding the same kind of coverage as dummy_index_am with a > couple of reloptions then? That can serve as a poin

Re: Add test module for Table Access Method

2024-01-15 Thread Michael Paquier
On Mon, Jan 15, 2024 at 03:40:30PM +0100, Jelte Fennema-Nio wrote: > On Mon, 15 Jan 2024 at 14:26, Aleksander Alekseev > wrote: >> To be fair, Postgres uses TAM internally, so there is at least one >> complete and up-to-date real-life example. > > Sure, but that one is quite hard to follow if you

Re: Add test module for Table Access Method

2024-01-15 Thread Jelte Fennema-Nio
On Mon, 15 Jan 2024 at 14:26, Aleksander Alekseev wrote: > To be fair, Postgres uses TAM internally, so there is at least one > complete and up-to-date real-life example. Sure, but that one is quite hard to follow if you don't already know lots of details of the heap storage. At least for me, hav

Re: Add test module for Table Access Method

2024-01-15 Thread Aleksander Alekseev
Hi, > When trying to implement a table access method in the past I remember > very well that I was having a really hard time finding an example of > one. To be fair, Postgres uses TAM internally, so there is at least one complete and up-to-date real-life example. Learning curve for TAMs is indeed

Re: Add test module for Table Access Method

2024-01-15 Thread Jelte Fennema-Nio
On Thu, 28 Sept 2023 at 03:08, Michael Paquier wrote: > dummy_index_am has included from the start additional coverage for the > various internal add_*_reloption routines, that were never covered in > the core tree. Except if I am missing something, I am not seeing some > of the extra usefulness

Re: Add test module for Table Access Method

2024-01-14 Thread vignesh C
On Thu, 28 Sept 2023 at 10:23, Michael Paquier wrote: > > On Sat, Jun 03, 2023 at 07:42:36PM -0400, Fabrízio de Royes Mello wrote: > > So in order to improve things a bit in this area I'm proposing to add a > > test module for Table Access Method similar what we already have for Index > > Access M

Re: Add test module for Table Access Method

2023-09-27 Thread Michael Paquier
On Sat, Jun 03, 2023 at 07:42:36PM -0400, Fabrízio de Royes Mello wrote: > So in order to improve things a bit in this area I'm proposing to add a > test module for Table Access Method similar what we already have for Index > Access Method. > > This code is based on the "blackhole_am" implemented

Re: Add test module for Table Access Method

2023-09-26 Thread Fabrízio de Royes Mello
ersion. -- Fabrízio de Royes Mello From 5b6642b520874f4ca7023fc33d2e8e875fb64693 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabr=C3=ADzio=20de=20Royes=20Mello?= Date: Sat, 3 Jun 2023 17:23:05 -0400 Subject: [PATCH v3] Add test module for Table Access Method --- src/test/modules/Makefil

Re: Add test module for Table Access Method

2023-06-05 Thread Fabrízio de Royes Mello
un 2023 17:23:05 -0400 Subject: [PATCH v2] Add test module for Table Access Method --- src/test/modules/Makefile | 1 + src/test/modules/dummy_table_am/.gitignore| 3 + src/test/modules/dummy_table_am/Makefile | 20 + src/test/modules/dummy_table_am/README

Add test module for Table Access Method

2023-06-03 Thread Fabrízio de Royes Mello
UTF-8?q?Fabr=C3=ADzio=20de=20Royes=20Mello?= Date: Sat, 3 Jun 2023 17:23:05 -0400 Subject: [PATCH] Add test module for Table Access Method --- src/test/modules/Makefile | 1 + src/test/modules/dummy_table_am/.gitignore| 3 + src/test/modules/dummy_table_am/Makefile