Re: Add system column support to the USING clause

2024-10-14 Thread Denis Garsh
If we are not going to implement this functionality, maybe it’s worth adding an explicit description to the [documentation](https://www.postgresql.org/docs/current/queries-table-expressions.html)? A note like: "JOIN USING doesn’t support system columns. If you need to join tables by a system co

Re: Add system column support to the USING clause

2024-09-26 Thread Denis Garsh
Hello, I'm still hoping for an answer. -- Best regards, Denis Garsh

Re: Add system column support to the USING clause

2024-09-16 Thread Denis Garsh
On 13.09.2024 17:56, Tom Lane wrote: I think this is an actively bad idea, and it was likely intentional that it's not supported today. A few reasons why: Thank you, Tom and David, for your feedback. I admit my mistake. I should have asked if this problem was worth solving before diving in.

Re: Add system column support to the USING clause

2024-09-13 Thread Tom Lane
Denis Garsh writes: > The patch adds support for system columns in JOIN USING clause. I think this is an actively bad idea, and it was likely intentional that it's not supported today. A few reasons why: * There are, fundamentally, no use-cases for joining on system columns. The only one that

Re: Add system column support to the USING clause

2024-09-13 Thread David G. Johnston
On Friday, September 13, 2024, David G. Johnston wrote: > > Link to PR on GitHub: https://github.com/hilltracer/postgres/pull/3 >> > > You apparently missed the note on GitHub that says we don’t work with pull > requests. Patches are to be submitted directly to the mailing list. > Sorry, I see

Re: Add system column support to the USING clause

2024-09-13 Thread David G. Johnston
On Friday, September 13, 2024, Denis Garsh wrote: > > > The patch adds support for system columns in JOIN USING clause. > Definitely not high on my list of oversights to fix. Resorting to the ON clause for the rare query that would need to do such a thing isn’t that costly. But as the patch exi

Add system column support to the USING clause

2024-09-13 Thread Denis Garsh
b.com/hilltracer/postgres/pull/3-- Best regards,  Denis Garsh,  d.ga...@arenadata.io From 295f9ec59b22cc3707fb8f168e0e3750e51724a0 Mon Sep 17 00:00:00 2001 From: Denis Garsh Date: Wed, 7 Aug 2024 15:57:32 +0300 Subject: [PATCH] Add system column support to the USING clause Problem: The parser can't ha