Re: Add support for INDEX_CLEANUP and TRUNCATE to vacuumdb

2020-06-22 Thread Bossart, Nathan
On 6/21/20, 9:36 PM, "Michael Paquier" wrote: > Okay. I have gone through the patch again, and applied it as of > 9550ea3. Thanks. Thanks! Nathan

Re: Add support for INDEX_CLEANUP and TRUNCATE to vacuumdb

2020-06-21 Thread Michael Paquier
On Fri, Jun 19, 2020 at 10:57:01AM +0900, Michael Paquier wrote: > Thanks. This flavor looks good to me in terms of code, and the test > coverage is what's needed for all the code paths added. This version > is using my suggestion of upthread for the option names: --no-truncate > and --no-index-c

Re: Add support for INDEX_CLEANUP and TRUNCATE to vacuumdb

2020-06-18 Thread Michael Paquier
On Thu, Jun 18, 2020 at 09:26:50PM +, Bossart, Nathan wrote: > It looks like I missed a couple of tags in the documentation changes. > That should be fixed in v3. Thanks. This flavor looks good to me in terms of code, and the test coverage is what's needed for all the code paths added. This

Re: Add support for INDEX_CLEANUP and TRUNCATE to vacuumdb

2020-06-11 Thread Masahiko Sawada
On Thu, 11 Jun 2020 at 09:41, Bossart, Nathan wrote: > > Hi hackers, > > I quickly put together a patch to add INDEX_CLEANUP and TRUNCATE to > vacuumdb before noticing a previous thread for it [0]. My take on it > was to just name the options --skip-index-cleanup and --skip-truncate. > While tha

Re: Add support for INDEX_CLEANUP and TRUNCATE to vacuumdb

2020-06-11 Thread Michael Paquier
On Thu, Jun 11, 2020 at 12:41:17AM +, Bossart, Nathan wrote: > I quickly put together a patch to add INDEX_CLEANUP and TRUNCATE to > vacuumdb before noticing a previous thread for it [0]. My take on it > was to just name the options --skip-index-cleanup and --skip-truncate. > While that does