Re: Add support for (Var op Var) clause in extended MCV statistics

2024-09-09 Thread Ilia Evdokimov
s['conditions'], 'no', actual_rows, '\t'.join(estimated_rows))) run_everywhere(conns, ['create statistics s (mcv) on a, b, c, d from t', 'commit', 'analyze']) with open('results.csv', 'a') as f: for conds in

Re: Add support for (Var op Var) clause in extended MCV statistics

2024-08-19 Thread Ilia Evdokimov
On 12.8.24 19:25, Tomas Vondra wrote: Is TPC-B really interesting/useful for this patch? The queries are super simple, with only a single clause (so it may not even get to the code handling extended statistics). Did you create any extended stats? No, it's not the case. I simply wanted to verif

Re: Add support for (Var op Var) clause in extended MCV statistics

2024-08-12 Thread Tomas Vondra
On 8/12/24 17:57, Ilia Evdokimov wrote: > On 12.8.24 14:53, Tomas Vondra wrote: > >> I agree, and I'm grateful someone picked up the original patch. I'll try >> to help to keep it moving forward. If the thread gets stuck, feel free >> to ping me to take a look. > Good. Thank you! >>> I started rev

Re: Add support for (Var op Var) clause in extended MCV statistics

2024-08-12 Thread Ilia Evdokimov
the performance did not drop. In general, it'd be better to do more tests and those listed by Tomas with new attached patch.From fa67b0fa34408c0f1b0c9f079b84e7c71f3b5599 Mon Sep 17 00:00:00 2001 From: Ilia Evdokimov Date: Sat, 10 Aug 2024 14:35:25 +0300 Subject: [PATCH] Add support fo

Re: Add support for (Var op Var) clause in extended MCV statistics

2024-08-12 Thread Tomas Vondra
On 8/12/24 13:44, Alena Rybakina wrote: > Hi! I think your work is important) > I agree, and I'm grateful someone picked up the original patch. I'll try to help to keep it moving forward. If the thread gets stuck, feel free to ping me to take a look. > I started reviewing it and want to suggest

Re: Add support for (Var op Var) clause in extended MCV statistics

2024-08-12 Thread Alena Rybakina
Hi! I think your work is important) I started reviewing it and want to suggest some changes to better code: I think we should consider the case where the expression is not neither an OpExpr and VarOpVar expression. Have you tested this code with any benchmarks? -- Regards, Alena Rybakina Pos

Re: Add support for (Var op Var) clause in extended MCV statistics

2024-08-12 Thread Ilia Evdokimov
Another issue mentioned in [1] involves cases where the clause is in the form (A op A). In my view, this isn't related to the current patch, as it can be addressed by rewriting the clause, similar to transforming A = A into A IS NOT NULL. This adjustment would result in more accurate estimation

Add support for (Var op Var) clause in extended MCV statistics

2024-08-12 Thread Ilia Evdokimov
s LLC. From fd468972f0ce27291523a28fdf0d9966c2fdf6e1 Mon Sep 17 00:00:00 2001 From: Ilia Evdokimov Date: Sat, 10 Aug 2024 14:35:25 +0300 Subject: [PATCH] Add support for (Var op Var) clause in extended MCV statistics Added a new leaf to the existing clauses tree, allowing the calculation of selecti