Re: Add some tests for pg_stat_statements compatibility verification under contrib

2021-10-03 Thread Michael Paquier
On Thu, Sep 30, 2021 at 11:12:21AM +0900, Michael Paquier wrote: > There is also no need for tests on 1.9, which is the latest version. > Tests for this one should be added once we bump the code to the next > version. At the end I finish with the attached, counting for the > back-and-forth game wi

Re: Add some tests for pg_stat_statements compatibility verification under contrib

2021-09-29 Thread Michael Paquier
On Wed, Aug 25, 2021 at 04:16:08PM +0900, Michael Paquier wrote: > I was just looking at your patch, and I think that you should move all > the past compatibility tests into a separate test file, in a way > consistent to what we do in contrib/pageinspect/ for > oldextversions.sql. I would suggest

Re: Add some tests for pg_stat_statements compatibility verification under contrib

2021-08-25 Thread Michael Paquier
On Mon, Mar 15, 2021 at 03:05:24PM +0800, Erica Zhang wrote: > This way the same query can be reused for both older versions and current > version. > Yep, it's neater to use the query as you suggested. Thanks! > > Also, can you register your patch for the next commitfest at > https://commitfest.po

Re: Add some tests for pg_stat_statements compatibility verification under contrib

2021-03-15 Thread Erica Zhang
Hi Julien, -- Original -- From: "Julien Rouhaud" https://com

Re: Add some tests for pg_stat_statements compatibility verification under contrib

2021-03-10 Thread Erica Zhang
Hi Julien, Thanks a lot for the quick review. Please see my answer below in blue. Attached is the new patch. -- Original -- From: "Julien Rouha

Re: Add some tests for pg_stat_statements compatibility verification under contrib

2021-03-09 Thread Julien Rouhaud
Hi Erica, On Wed, Mar 10, 2021 at 11:14:52AM +0800, Erica Zhang wrote: > Hi Julien, > Thanks a lot for the quick review. Please see my answer below in blue. > Attached is the new patch. Thanks! >> The upgrade scripts are already tested as postgres will install 1.4 and >> perform >> all upgrade

Re: Add some tests for pg_stat_statements compatibility verification under contrib

2021-03-09 Thread Julien Rouhaud
Hi, On Tue, Mar 09, 2021 at 11:35:14AM +0800, Erica Zhang wrote: > Hi All, > On the master branch, it is possible to install multiple versions of > pg_stat_statements with CREATE EXTENSION, but all the tests in sql/ on look > at the latest version available, without testing past compatibility.

Add some tests for pg_stat_statements compatibility verification under contrib

2021-03-09 Thread Erica Zhang
Hi All, On the master branch, it is possible to install multiple versions of pg_stat_statements with CREATE EXTENSION, but all the tests in sql/ on look at the latest version available, without testing past compatibility. Since we support to install lowest version 1.4 currently, add some tests