On 2024/11/21 15:43, torikoshia wrote:
Thanks for the update! Agreed.
I think the validator tests related to the on_error option you added are
sufficient.
I've pushed the patch. Thanks!
As for the other file_fdw options, I'm a bit concerned whether it would be
better to add validator tes
On 2024-11-21 00:43, Fujii Masao wrote:
On 2024/11/19 21:40, torikoshia wrote:
These messages may be unexpected for some users because the
documentation of
fild_fdw does not explicitly describe that file_fdw uses COPY
internally.
(I can find several wordings like "as COPY", though.)
However, s
On 2024/11/19 21:40, torikoshia wrote:
These messages may be unexpected for some users because the documentation of
fild_fdw does not explicitly describe that file_fdw uses COPY internally.
(I can find several wordings like "as COPY", though.)
However, since the current file_fdw already has suc
options?
That might be better.
Added some queries which had wrong options to cause errors.
I was unsure whether to add it to "validator test" section or "on_error,
log_verbosity and reject_limit tests" section, but I chose "validator
test" as I believe it makes t
On Wed, 13 Nov 2024 21:48:10 +0900
torikoshia wrote:
> On 2024-11-12 14:51, Yugo Nagata wrote:
>
> Thanks for your review!
>
> > On Tue, 12 Nov 2024 10:16:50 +0900
> > torikoshia wrote:
> >
> >> On 2024-11-12 01:49, Fujii Masao wrote:
> >> > On 2024/11/11 21:45, torikoshia wrote:
> >> >>> Tha
ed more than reject_limit ..."
rather
than using uppercase?
Agreed.
Attached v4 patch.
--
Regards,
--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.From 114d8dd2c57bf8b9cf712b8fa401c7b8eaa8a958 Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi
Date: Wed, 13 Nov 2024 21:32:25 +0900
Su
On 2024-11-12 15:23, Kirill Reshke wrote:
Thanks for your review!
On Tue, 12 Nov 2024 at 06:17, torikoshia
wrote:
On 2024-11-12 01:49, Fujii Masao wrote:
> On 2024/11/11 21:45, torikoshia wrote:
>>> Thanks for adding the comment. It clearly states that REJECT_LIMIT
>>> can be
>>> a single-qu
On Tue, 12 Nov 2024 at 06:17, torikoshia wrote:
>
> On 2024-11-12 01:49, Fujii Masao wrote:
> > On 2024/11/11 21:45, torikoshia wrote:
> >>> Thanks for adding the comment. It clearly states that REJECT_LIMIT
> >>> can be
> >>> a single-quoted string. However, it might also be helpful to mention
>
On Tue, 12 Nov 2024 10:16:50 +0900
torikoshia wrote:
> On 2024-11-12 01:49, Fujii Masao wrote:
> > On 2024/11/11 21:45, torikoshia wrote:
> >>> Thanks for adding the comment. It clearly states that REJECT_LIMIT
> >>> can be
> >>> a single-quoted string. However, it might also be helpful to menti
6380a1a52e125671cfecb3a9056019ff85a32dd7 Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi
Date: Mon, 11 Nov 2024 21:36:57 +0900
Subject: [PATCH v3] file_fdw: Add reject_limit option to file_fdw
Commit 4ac2a9bece introduced REJECT_LIMIT option for COPY. This patch
extends support for this option to file_fdw
On 2024/11/11 21:45, torikoshia wrote:
Thanks for adding the comment. It clearly states that REJECT_LIMIT can be
a single-quoted string. However, it might also be helpful to mention that
it can be provided as an int64 in the COPY command option. How about
updating it like this?
--
On 2024-11-08 01:44, Fujii Masao wrote:
Thanks for your review!
On 2024/11/05 22:30, torikoshia wrote:
Thanks for the patch! Could you add it to the next CommitFest?
Added an entry for this patch:
https://commitfest.postgresql.org/50/5331/
Thanks!
+ALTER FOREIGN TABLE agg_bad OPTIONS (re
On 2024/11/05 22:30, torikoshia wrote:
Thanks for the patch! Could you add it to the next CommitFest?
Added an entry for this patch:
https://commitfest.postgresql.org/50/5331/
Thanks!
+ALTER FOREIGN TABLE agg_bad OPTIONS (reject_limit '1');
+SELECT * FROM agg_bad;
+ a | b
+-+---
00:00:00 2001
From: Atsushi Torikoshi
Date: Tue, 5 Nov 2024 21:57:16 +0900
Subject: [PATCH v2] file_fdw: Add reject_limit option to file_fdw
Commit 4ac2a9bece introduced REJECT_LIMIT option for COPY. This patch
extends support for this option to file_fdw.
As well as REJECT_LIMIT option for COPY,
On 2024/10/17 22:45, torikoshia wrote:
Hi,
4ac2a9bec introduced reject_limit option to the COPY command, and I was
wondering if it might be beneficial to add the same option to file_fdw.
Although there may be fewer practical use cases compared to COPY, it could
still be useful in situation
2001
From: Atsushi Torikoshi
Date: Thu, 17 Oct 2024 22:19:06 +0900
Subject: [PATCH v1] file_fdw: Add reject_limit option to file_fdw
---
contrib/file_fdw/expected/file_fdw.out | 10 +-
contrib/file_fdw/file_fdw.c| 8
contrib/file_fdw/sql/file_fdw.sql | 4 +++
16 matches
Mail list logo
