Re: Add publisher and subscriber to glossary documentation.

On Fri, Mar 15, 2024, at 1:14 AM, Amit Kapila wrote: > I think node should mean instance for both physical and logical > replication, otherwise, it would be confusing. We need both the usages > as a particular publication/subscription is defined at the database > level but the server on which we de

Re: Add publisher and subscriber to glossary documentation.

On Thu, Mar 14, 2024 at 7:51 PM Alvaro Herrera wrote: > > On 2024-Mar-14, Shlok Kyal wrote: > > > Andrew Atkinson wrote: > > > > > Anyway, hopefully these examples show “node” and “database” are > > > mixed and perhaps others agree using one consistently might help the > > > goals of the docs. > >

Re: Add publisher and subscriber to glossary documentation.

On 2024-Mar-14, Shlok Kyal wrote: > Andrew Atkinson wrote: > > > Anyway, hopefully these examples show “node” and “database” are > > mixed and perhaps others agree using one consistently might help the > > goals of the docs. > > For me the existing content looks good, I felt let's keep it as it i

Re: Add publisher and subscriber to glossary documentation.

Hi Andrew, > If there's a movement towards "node" to refer to the database which has the > Subscription object, then perhaps the documentation for > > 31.2. Subscription, Chapter 31. Logical Replication should be updated as > well, since it uses both the "database" and "node" terms on the same p

Re: Add publisher and subscriber to glossary documentation.

If there's a movement towards "node" to refer to the database which has the Subscription object, then perhaps the documentation for 31.2. Subscription, Chapter 31. Logical Replication should be updated as well, since i

Re: Add publisher and subscriber to glossary documentation.

Hi, the patch v4 LGTM. == Kind Regards, Peter Smith. Fujitsu Australia

Re: Add publisher and subscriber to glossary documentation.

> 1. > + > + Publication node > + > + > + A node where a > + linkend="glossary-publication">publication is defined > + for logical > replication. > + > + > + > + > > I felt the word "node" here should link to the glossary term "Node", > instead of directly to the te

Re: Add publisher and subscriber to glossary documentation.

Here are some comments for patch v3: 1. + + Publication node + + + A node where a + publication is defined + for logical replication. + + + + I felt the word "node" here should link to the glossary term "Node", instead of directly to the term "Instance". ~~ 2. +

Re: Add publisher and subscriber to glossary documentation.

> Here are some comments for patch v2. > > == > > 1. There are whitespace problems > > [postgres@CentOS7-x64 oss_postgres_misc]$ git apply > ../patches_misc/v2-0001-Add-publisher-and-subscriber-to-glossary-document.patch > ../patches_misc/v2-0001-Add-publisher-and-subscriber-to-glossary-documen

Re: Add publisher and subscriber to glossary documentation.

Here are some comments for patch v2. == 1. There are whitespace problems [postgres@CentOS7-x64 oss_postgres_misc]$ git apply ../patches_misc/v2-0001-Add-publisher-and-subscriber-to-glossary-document.patch ../patches_misc/v2-0001-Add-publisher-and-subscriber-to-glossary-document.patch:43: tra

Re: Add publisher and subscriber to glossary documentation.

Hi, I addressed the comments and updated the patch. > Should these be "publisher node" and "subscriber node" instead? Do we > want to define the term "node"? I think in everyday conversations we > use "node" quite a lot, so maybe we do need an entry for it. (Maybe > just suffices, plus add und

Re: Add publisher and subscriber to glossary documentation.

Hello On 2024-Feb-12, Shlok Kyal wrote: > There are several places where publisher and subscriber terms are used > across the documentation. But the publisher and subscriber were > missing in the documentation. I felt this should be added in the > glossary. I agree, but let's wordsmith those def

Add publisher and subscriber to glossary documentation.

Hi, There are several places where publisher and subscriber terms are used across the documentation. But the publisher and subscriber were missing in the documentation. I felt this should be added in the glossary. I have created a patch for the same. Thanks and Regards Shlok Kyal v1-0001-Add-pu