> On 25 Apr 2024, at 18:16, Robert Haas wrote:
>
> On Wed, Apr 24, 2024 at 3:08 PM Daniel Gustafsson wrote:
>> LGTM; only one small comment which you can ignore if you feel it's not worth
>> the extra words.
>>
>> +pg_combinebackup when the checksum status of the
>> +cluster has been ch
On Wed, Apr 24, 2024 at 3:08 PM Daniel Gustafsson wrote:
> LGTM; only one small comment which you can ignore if you feel it's not worth
> the extra words.
>
> +pg_combinebackup when the checksum status of the
> +cluster has been changed; see
>
> I would have preferred that this sentence in
> On 22 Apr 2024, at 20:52, Robert Haas wrote:
>
> On Thu, Apr 18, 2024 at 3:25 PM Daniel Gustafsson wrote:
>>> On 18 Apr 2024, at 20:11, Robert Haas wrote:
>>> 2. As (1), but make check_control_files() emit a warning message when
>>> the problem case is detected.
>>
>> Being in the post-freez
On Mon, Apr 22, 2024 at 2:52 PM Robert Haas wrote:
> On Thu, Apr 18, 2024 at 3:25 PM Daniel Gustafsson wrote:
> > > On 18 Apr 2024, at 20:11, Robert Haas wrote:
> > > 2. As (1), but make check_control_files() emit a warning message when
> > > the problem case is detected.
> >
> > Being in the po
On Thu, Apr 18, 2024 at 3:25 PM Daniel Gustafsson wrote:
> > On 18 Apr 2024, at 20:11, Robert Haas wrote:
> > 2. As (1), but make check_control_files() emit a warning message when
> > the problem case is detected.
>
> Being in the post-freeze part of the cycle, this seems like the best option.
H
On Thu, Apr 18, 2024 at 3:25 PM Daniel Gustafsson wrote:
> I don't think this is the way to go, such an option will be plastered on to
> helpful tutorials which users will copy/paste from even when they don't need
> the option at all, only to disable checksums when there was no reason for
> doing
> On 18 Apr 2024, at 20:11, Robert Haas wrote:
> 2. As (1), but make check_control_files() emit a warning message when
> the problem case is detected.
Being in the post-freeze part of the cycle, this seems like the best option.
> 3. As (2), but also add a command-line option to pg_combinebackup
On Tue, Apr 9, 2024 at 5:46 AM Tomas Vondra
wrote:
> What we could do is detect this in pg_combinebackup, and either just
> disable checksums with a warning and hint to maybe enable them again. Or
> maybe just print that the user needs to disable them.
>
> I was thinking maybe we could detect this
On Tue, Apr 9, 2024 at 4:00 AM Martín Marqués wrote:
> I've attached two patches, the first one is just neat-picking things I
> found when I first read the docs.
I pushed a commit to remove the spurious "the" that you found, but I
don't really agree with the other changes. They all seem grammatic
On 4/12/24 22:40, Tomas Vondra wrote:
On 4/12/24 11:50, David Steele wrote:
On 4/12/24 19:09, Magnus Hagander wrote:
On Fri, Apr 12, 2024 at 12:14 AM David Steele >
> But yeah, having to keep the backups as expanded directories is
not
> great, I'd love to have .tar. Not necessari
On Fri, Apr 12, 2024 at 3:01 PM Tomas Vondra
wrote:
>
>
> On 4/12/24 11:12, Magnus Hagander wrote:
> > On Tue, Apr 9, 2024 at 11:46 AM Tomas Vondra <
> tomas.von...@enterprisedb.com>
> > wrote:
> >
> >>
> >>
> >> On 4/9/24 09:59, Martín Marqués wrote:
> >>> Hello,
> >>>
> >>> While doing some wor
On 4/12/24 11:12, Magnus Hagander wrote:
> On Tue, Apr 9, 2024 at 11:46 AM Tomas Vondra
> wrote:
>
>>
>>
>> On 4/9/24 09:59, Martín Marqués wrote:
>>> Hello,
>>>
>>> While doing some work/research on the new incremental backup feature
>>> some limitations were not listed in the docs. Mainly th
On 4/12/24 11:50, David Steele wrote:
> On 4/12/24 19:09, Magnus Hagander wrote:
>> On Fri, Apr 12, 2024 at 12:14 AM David Steele >
>> ...>>
>> > But yeah, having to keep the backups as expanded directories is
>> not
>> > great, I'd love to have .tar. Not necessarily because of the disk
>
On 4/12/24 19:09, Magnus Hagander wrote:
On Fri, Apr 12, 2024 at 12:14 AM David Steele
OK, sure, but if the plan is to make it practical later doesn't that
make the feature something to be avoided now?
That could be said for any feature. When we shipped streaming
replication, the plan
On Tue, Apr 9, 2024 at 11:46 AM Tomas Vondra
wrote:
>
>
> On 4/9/24 09:59, Martín Marqués wrote:
> > Hello,
> >
> > While doing some work/research on the new incremental backup feature
> > some limitations were not listed in the docs. Mainly the fact that
> > pg_combienbackup works with plain for
On Fri, Apr 12, 2024 at 12:14 AM David Steele wrote:
>
>
> On 4/11/24 20:51, Tomas Vondra wrote:
> > On 4/11/24 02:01, David Steele wrote:
> >>
> >> I have a hard time seeing this feature as being very useful, especially
> >> for large databases, until pg_combinebackup works on tar (and compresse
On 4/11/24 20:51, Tomas Vondra wrote:
On 4/11/24 02:01, David Steele wrote:
I have a hard time seeing this feature as being very useful, especially
for large databases, until pg_combinebackup works on tar (and compressed
tar). Right now restoring an incremental requires at least twice the
sp
On 4/11/24 02:01, David Steele wrote:
> On 4/9/24 19:44, Tomas Vondra wrote:
>>
>> On 4/9/24 09:59, Martín Marqués wrote:
>>> Hello,
>>>
>>> While doing some work/research on the new incremental backup feature
>>> some limitations were not listed in the docs. Mainly the fact that
>>> pg_combienback
On 4/9/24 19:44, Tomas Vondra wrote:
On 4/9/24 09:59, Martín Marqués wrote:
Hello,
While doing some work/research on the new incremental backup feature
some limitations were not listed in the docs. Mainly the fact that
pg_combienbackup works with plain format and not tar.
Right. The docs mo
On 4/9/24 09:59, Martín Marqués wrote:
> Hello,
>
> While doing some work/research on the new incremental backup feature
> some limitations were not listed in the docs. Mainly the fact that
> pg_combienbackup works with plain format and not tar.
>
Right. The docs mostly imply this by talking
Hello,
While doing some work/research on the new incremental backup feature
some limitations were not listed in the docs. Mainly the fact that
pg_combienbackup works with plain format and not tar.
Around the same time, Tomas Vondra tested incremental backups with a
cluster where he enabled checks
21 matches
Mail list logo
