On 09.04.25 12:02, Peter Eisentraut wrote:
I ran src/tools/mark_pgdllimport.pl and it detected a few new global
variables with missing markings. See attached patch. Please point out
if any of these should not be marked or if they are special cases in
some other way. I'm Cc'ing various people
On Wed, Apr 9, 2025 at 4:48 AM Daniel Gustafsson wrote:
> -extern const pg_be_sasl_mech pg_be_oauth_mech;
> +extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech;
> +1 on this.
LGTM, too.
Thanks!
--Jacob
> On 9 Apr 2025, at 13:48, Daniel Gustafsson wrote:
>> On 9 Apr 2025, at 12:02, Peter Eisentraut wrote:
>> could probably do with a less generic name?
>
> Good point, unless objected to I'll apply the attached renaming which then
> also
> contain the PGDLLIMPORT addition.
Done.
--
Daniel Gus
Robert Haas writes:
> The issue we're going to run into is that a lot of extension authors
> like to call things that the core developers probably think they
> shouldn't. If we lock it down, we'll either be breaking a bunch of
> extensions that are doing sneaky things that somebody has managed to
On Wed, Apr 9, 2025 at 1:10 PM Andres Freund wrote:
> I think eventually we ought to change the default visibility in the main
> binary to hidden, just like we do for extensions. Then the windows/everything
> else behavior difference vanishes and we actually get the benefit of being
> more rest
Btw., this new variable in memutils.h
extern dsa_area *area;
could probably do with a less generic name?
From e9d868a38b50c1fa449258926c40cef88bd73045 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 9 Apr 2025 11:55:48 +0200
Subject: [PATCH] WIP: Add missing PGDLLIMPORT markings
On Wed, Apr 9, 2025 at 11:28 AM Andres Freund wrote:
> FWIW, the AIO ones really don't make sense to make public - the only reason
> for those variables to exists is so they can be put into an array of
> callbacks. There's no way an extension could ever benefit from them. But I
> guess we don't r
Hi,
On April 9, 2025 12:58:23 PM EDT, Robert Haas wrote:
>On Wed, Apr 9, 2025 at 11:28 AM Andres Freund wrote:
>> FWIW, the AIO ones really don't make sense to make public - the only reason
>> for those variables to exists is so they can be put into an array of
>> callbacks. There's no way an e
Hi,
On 2025-04-09 12:02:52 +0200, Peter Eisentraut wrote:
> I ran src/tools/mark_pgdllimport.pl and it detected a few new global
> variables with missing markings. See attached patch. Please point out if
> any of these should not be marked or if they are special cases in some other
> way. I'm C
> On 9 Apr 2025, at 12:02, Peter Eisentraut wrote:
-extern const pg_be_sasl_mech pg_be_oauth_mech;
+extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech;
+1 on this.
> Btw., this new variable in memutils.h
>
>extern dsa_area *area;
>
> could probably do with a less generic name?
Good
10 matches
Mail list logo
